[docs] Typo in class io.BufferedIOBase docs (issue 22671)

vadmium+py at gmail.com vadmium+py at gmail.com
Sun Mar 22 00:09:01 CET 2015


https://bugs.python.org/review/22671/diff/13484/Lib/test/test_io.py
File Lib/test/test_io.py (right):

https://bugs.python.org/review/22671/diff/13484/Lib/test/test_io.py#newcode608
Lib/test/test_io.py:608: # Exercise the default RawIOBase.read() and
readall() implementations
On 2015/03/21 19:22:00, storchaka wrote:
> May be create separate test for readall?

Okay

https://bugs.python.org/review/22671/diff/13484/Lib/test/test_io.py#newcode636
Lib/test/test_io.py:636: dict(method="readinto", avail=10, request=5,
result=5),
On 2015/03/21 19:22:00, storchaka wrote:
> This is too verbose. Tuples would look cleaner. And testing code with
> test["..."] looks untidy.

Perhaps a matrix of tuples with a comment at the top saying what the
columns are would work.

https://bugs.python.org/review/22671/diff/13484/Lib/test/test_io.py#newcode644
Lib/test/test_io.py:644: )
On 2015/03/21 19:22:00, storchaka wrote:
> Does it make sense to add tests for request=0 or -1?

request=0: yes; request=-1: no, because you can’t have a bytearray -1
bytes long :)

https://bugs.python.org/review/22671/


More information about the docs mailing list