[docs] TypeError in smtpd module with string arguments (issue 26209)

ghost.adh at runbox.com ghost.adh at runbox.com
Mon Aug 8 05:49:18 EDT 2016


https://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst
File Doc/library/smtpd.rst (right):

https://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode35
Doc/library/smtpd.rst:35: *localaddr*.  It will treat *remoteaddr* as an
upstream SMTP relayer. Both
Two spaces between the sentences are required.

https://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode36
Doc/library/smtpd.rst:36: the parameters localaddr and remoteaddr should
a tuple in form ``("host",portnumber)``,
Please make sure that each line fits into 80 columns.

https://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode36
Doc/library/smtpd.rst:36: the parameters localaddr and remoteaddr should
a tuple in form ``("host",portnumber)``,
How about this wording: "Both *localaddr* and *remoteaddr* should be a
two-tuple in the form ``('host', portnumber)``...

https://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode37
Doc/library/smtpd.rst:37: where *host* is a valid   IP/FQDN. It inherits
from :class:`asyncore.dispatcher`,
Only single space between words.

https://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode37
Doc/library/smtpd.rst:37: where *host* is a valid   IP/FQDN. It inherits
from :class:`asyncore.dispatcher`,
I'd suggest replacing "It" with "The object".

https://bugs.python.org/review/26209/


More information about the docs mailing list