[ expat-Patches-458907 ] config.h appears to be unused

noreply@sourceforge.net noreply@sourceforge.net
Thu Nov 8 20:49:01 2001


Patches item #458907, was opened at 2001-09-05 14:20
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=310127&aid=458907&group_id=10127

Category: Build Control
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Martin v. L÷wis (loewis)
Assigned to: Greg Stein (gstein)
Summary: config.h appears to be unused

Initial Comment:
To compile expat as part of another package (e.g. 
PyXML), the expat configure might not have been run. 
For that kind of application, it is necessary to wrap 
each occurrence of config.h into HAVE_CONFIG_H; the 
attached patch does that.

While trying to figure out which of the defines are 
needed, it appears that none of them are (i.e. HAVE_ 
is never used). For stand-along compilation, I found 
that only VERSION, XML_NS, XML_DTD, XML_BYTE_ORDER, 
and XML_CONTEXT_BYTES must be defined. Is that 
impression correct?


----------------------------------------------------------------------

>Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-11-08 20:48

Message:
Logged In: YES 
user_id=3066

It certainly looks like it can be reduced and possibly
removed; I'll read up on a few of the autoconf things before
removing it completely.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=310127&aid=458907&group_id=10127