[ expat-Patches-566901 ] install (if building outside the sourcedir) fails

noreply@sourceforge.net noreply@sourceforge.net
Wed Jun 12 07:45:06 2002


Patches item #566901, was opened at 2002-06-10 17:30
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=310127&aid=566901&group_id=10127

Category: Build Control
Group: None
Status: Open
Resolution: None
Priority: 7
Submitted By: Gerrit Haase (siebenschlaefer)
Assigned to: Greg Stein (gstein)
Summary: install (if building outside the sourcedir) fails

Initial Comment:
1. It is not possible to build outside the sourcedir.
Starts with wrong paths and after fixing this I get 
problems because expat.h and the manfile were not 
found. e.g. error , please see below.
2. Calling autoconf gives this message:
    conftools/get-version.sh: not found


/usr/bin/install -c 
lib/.libs/libexpat.dll.a /var/www/htdocs/cywgin/ex
pat/test/expat-1.95.3/.inst/usr/lib/libexpat.dll.a
dlpath=`bash 2>&1 -c '. 
lib/.libs/lib/libexpat.lai;echo $dlname'`
 dldir=/var/www/htdocs/cywgin/expat/test/expat-
1.95.3/.inst/usr/lib/`dirname $dlpath`
dirname: too many arguments
Try `dirname --help' for more information.
make: *** [installlib] Error 1


Attached is the diff from my changes to Makefile.in 
to get it to install successfull outside the sourcedir.


Gerrit
-- 
=^..^=

----------------------------------------------------------------------

>Comment By: Gerrit Haase (siebenschlaefer)
Date: 2002-06-12 16:44

Message:
Logged In: YES 
user_id=76037

Hi David,

you wrote:
>Gerrit's patch almost works for me. However, I also had
>to change

>  INCLUDES = -Ilib -I.

>to

>  INCLUDES = -I$(srcdir)/lib -I.


you are right.  This is an oversight from me, since I have 
expat already installed in the standard locations I got no 
problems.  This needs to be fixed in my latest package 
which I offered for inclusion to the Cygwin netrelease.

>Moreover, I don't understand the need
>for the docdir macro.  There's no target that uses this, 
>AFAICT.

Yes, also true, this is only used for internal (Cygwin) 
use, we install docs into /usr/doc/${package-name},
I wanted to create the docdir from the make run, but 
never used it. (docs here are including license 
information and the README included in the expat 
source dist.)

I do this with my build script, no need to include it in 
the dist since expat doesn't install docs besides the 
manfile.


Many thanks for your patch review;)

Gerrit
-- 
=^..^=

----------------------------------------------------------------------

Comment By: Gerrit Haase (siebenschlaefer)
Date: 2002-06-12 16:43

Message:
Logged In: YES 
user_id=76037

Hi David,

you wrote:
>Gerrit's patch almost works for me. However, I also had
>to change

>  INCLUDES = -Ilib -I.

>to

>  INCLUDES = -I$(srcdir)/lib -I.


you are right.  This is an oversight from me, since I have 
expat already installed in the standard locations I got no 
problems.  This needs to be fixed in my latest package 
which I offered for inclusion to the Cygwin netrelease.

>Moreover, I don't understand the need
>for the docdir macro.  There's no target that uses this, 
>AFAICT.

Yes, also true, this is only used for internal (Cygwin) 
use, we install docs into /usr/doc/${package-name},
I wanted to create the docdir from the make run, but 
never used it. (docs here are including license 
information and the README included in the expat 
source dist.)

I do this with my build script, no need to include it in 
the dist since expat doesn't install docs besides the 
manfile.


Many thanks for your patch review;)

Gerrit
-- 
=^..^=

----------------------------------------------------------------------

Comment By: David Starks-Browning (davidsb)
Date: 2002-06-12 16:06

Message:
Logged In: YES 
user_id=561928

Yes, please do get "make" and "make install" working when building outside the source tree.
I also need it, and not for Cygwin. :-)

Gerrit's patch almost works for me. However, I also had to change

  INCLUDES = -Ilib -I.

to

  INCLUDES = -I$(srcdir)/lib -I.

Gerrit, if you didn't need this, then you probably compiled with whatever expat.h had been installed
in the default location (or as augmented by CPPFLAGS).

Moreover, I don't understand the need
for the docdir macro.  There's no target that uses this, AFAICT.

For the record, I had reported similar problems with 1.95.1 in bug #406262, but had not tracked expat
development since then.

Thanks everyone!

David

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=310127&aid=566901&group_id=10127