[Expat-bugs] [ expat-Bugs-699323 ] VMS: descrip.mms incomplete (1.95.6 et al)

[SourceForge.net]

Bugs item #699323, was opened at 2003-03-07 06:36
Message generated for change (Comment added) made by fdrake
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=699323&group_id=10127

Category: Build control
Group: Platform Specific
>Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: VMS: descrip.mms incomplete (1.95.6 et al)

Initial Comment:
MMS fails after updating library with:
%MMS-F-GWKNOACTS, Actions to update ALL are unknown.

Fix: replace the "all : $(library)" line with:

"all : sys$common:[syslib]$(LIBRARY),
sys$common:[syslib]expat.h
        @ !

sys$common:[syslib]$(library) : $(library)
        copy/log $(mms$source) $(mms$target)

sys$common:[syslib]expat.h : $(apiheader)
        copy/log $(mms$source) $(mms$target)

"
NB: it's important that each rule consists of  a 1-line
'dependency' followed by a 1-line 'action' followed by
a blank line.
The spaces are important too.
(Yes, MMS *is* very picky)

    - chris.sharman at ccagroup.co.uk

----------------------------------------------------------------------

>Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2003-07-21 10:02

Message:
Logged In: YES 
user_id=3066

Great.  Closing the bug report.

----------------------------------------------------------------------

Comment By: Craig A. Berry (berryc)
Date: 2003-07-21 01:06

Message:
Logged In: YES 
user_id=717096

Thanks, Fred.  I've just tested what's in CVS and it builds fine.

----------------------------------------------------------------------

Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2003-07-16 08:23

Message:
Logged In: YES 
user_id=3066

I've applied the patch from berryc as vms/descrip.mms
revision 1.2.
Please check out the CVS version and confirm that I didn't
make any errors; I have no access to a VMS machine (or
enough knowledge to make use of one if I did).

----------------------------------------------------------------------

Comment By: Craig A. Berry (berryc)
Date: 2003-03-16 16:33

Message:
Logged In: YES 
user_id=717096

The suggested fix is incorrect because it installs the object library and expat.h in a system directory as part of the build process. It's questionable whether a package should ever put its own files in sys$common:[syslib], and if it does, it should do so as part of a separate install step (not currently implemented) and not as part of the initial make.

There is nothing wrong with not having an action line, but it does lead to a less than informative message in the case of the "all" target, which exists solely to drive the other dependencies.  The patch below is all that's needed to replace that message with something more informative:

--- vms/descrip.mms;-0  Tue Jun  4 23:13:10 2002
+++ vms/descrip.mms  Sun Mar 16 14:47:46 2003
@@ -40,2 +40,3 @@
 all : $(LIBRARY)
+        @ write sys$output "All made."
 
[end of patch]

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=699323&group_id=10127