[Expat-bugs] [ expat-Patches-1437840 ] Compile fix rollup patch against 2.0.0
SourceForge.net
noreply at sourceforge.net
Mon Feb 27 15:26:16 CET 2006
Patches item #1437840, was opened at 2006-02-23 21:58
Message generated for change (Comment added) made by kwaclaw
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=310127&aid=1437840&group_id=10127
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Mark F. Haigh (mfhaigh)
Assigned to: Greg Stein (gstein)
Summary: Compile fix rollup patch against 2.0.0
Initial Comment:
The attached rollup patch fixes the following bugs:
#1414066 - make failes on hpux
#1033965 - Building application fails with Intel C
compiler (1.95.7)
#N/A - Build fails on Tru64 UNIX.
The patch was tested on x86-64 Linux, i386 NetBSD,
HP-UX 11i, and Tru64 5.1b. All tests passed on each
machine.
----------------------------------------------------------------------
>Comment By: Karl Waclawek (kwaclaw)
Date: 2006-02-27 09:26
Message:
Logged In: YES
user_id=290026
One question about the patch to runtests.c:
- int callno = 1 + (int)XML_GetUserData(parser);
+ long callno = 1 + (long)XML_GetUserData(parser);
Why changing from int to long?
If we really want to be anal, why not change to ptrdiff_t,
as callno hast to fit into a pointer?
----------------------------------------------------------------------
Comment By: Karl Waclawek (kwaclaw)
Date: 2006-02-24 10:16
Message:
Logged In: YES
user_id=290026
Thanks.
Seems to work on Cygwin as well.
Will check it in if Greg has no objections.
----------------------------------------------------------------------
Comment By: Mark F. Haigh (mfhaigh)
Date: 2006-02-23 23:10
Message:
Logged In: YES
user_id=1458985
The patch was against the 2.0.0 release. I'm attaching the
same patch against CVS as of Feb 23, 2006, 8:00 PST.
----------------------------------------------------------------------
Comment By: Karl Waclawek (kwaclaw)
Date: 2006-02-23 22:10
Message:
Logged In: YES
user_id=290026
Is this patch against CVS?
It fails for me on Makefile.in:
$ patch -i compile-rollup.patch -p 1
patching file lib/expat_external.h
patching file Makefile.in
Hunk #3 succeeded at 157 (offset 1 line).
Hunk #4 FAILED at 172.
1 out of 4 hunks FAILED -- saving rejects to file
Makefile.in.rej
patching file tests/minicheck.h
patching file tests/runtests.c
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=310127&aid=1437840&group_id=10127
More information about the Expat-bugs
mailing list