[Expat-bugs] [ expat-Bugs-1717322 ] .def file directives throw link warnings

[SourceForge.net]

Bugs item #1717322, was opened at 2007-05-11 12:34
Message generated for change (Comment added) made by kwaclaw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=1717322&group_id=10127

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build control
>Group: Test Required
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Kevin J Bluck (kbluck)
Assigned to: Greg Stein (gstein)
Summary: .def file directives throw link warnings

Initial Comment:
CVS Tag: R_2_0_0

libexpat.def and libexpatw.def for Windows DLL builds both include two elements that cause link warnings and in some cases, make the DLL unuseable at runtime.

The first line of each file, the LIBRARY directive, includes an explicit library name. This effectively prevents custom builds with a different DLL name. If you attempt to build a DLL with a different name, the linker will throw LNK4070 'filename directive differs from output filename' and the import lib will cause applications to link against the DEF LIBRARY DLL name instead of the actual DLL file name, which of course causes a "DLL not found" error at runtime.

To prevent this, that line should read just 'LIBRARY' with no name specified.

The next line is a DESCRIPTION directive. This line causes a LNK4017 warning 'statement not supported'. This directive has been deprecated for years in favor of version resources, and should be eliminated completely.


----------------------------------------------------------------------

>Comment By: Karl Waclawek (kwaclaw)
Date: 2007-05-11 12:55

Message:
Logged In: YES 
user_id=290026
Originator: NO

Fixed in libexpat(w).dev rev. 1.8.
Please check out and test.

Karl

----------------------------------------------------------------------

Comment By: Kevin J Bluck (kbluck)
Date: 2007-05-11 12:40

Message:
Logged In: YES 
user_id=11142
Originator: YES

I would have generated a patch, but your CVS seems to be rejecting
anonymous access at the moment. Strange, it wasn't doing that a couple days
ago.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=1717322&group_id=10127