[Expat-bugs] [ expat-Bugs-1895659 ] wrong expression

[SourceForge.net]

Bugs item #1895659, was opened at 2008-02-17 17:06
Message generated for change (Comment added) made by fdrake
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=1895659&group_id=10127

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: www.libexpat.org
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: wrong expression

Initial Comment:
Dear Sir or Madam,

I found a minor bugs in Expat 2.0.1.

xmltok_impl.c Line 1661:
  if (MINBPC(enc) == 1 && *ptr1 == *ptr2)
should be
  if ((MINBPC(enc) == 1) && (*ptr1 == *ptr2))

since && has a higher priority than ==.


Sincerely,
Sebastian Gottschalk

----------------------------------------------------------------------

>Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2008-02-18 15:41

Message:
Logged In: YES 
user_id=3066
Originator: NO

schiele's right; rejecting this as not-a-bug.

----------------------------------------------------------------------

Comment By: Robert Schiele (schiele)
Date: 2008-02-17 17:31

Message:
Logged In: YES 
user_id=8099
Originator: NO

No, precedence of == is higher than &&.

Though putting parentheses there might be considered better programming
style this is definitely no bug.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=1895659&group_id=10127