[Expat-bugs] [ expat-Bugs-2990652 ] CMake Build system

[SourceForge.net]

Bugs item #2990652, was opened at 2010-04-21 17:35
Message generated for change (Comment added) made by kwaclaw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=2990652&group_id=10127

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build control
Group: Feature Request
Status: Open
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: SaroEngels (pspendrin)
Assigned to: Karl Waclawek (kwaclaw)
Summary: CMake Build system

Initial Comment:
I am maintaining the 3rdparty libraries for the KDE Windows port. For this we developed a CMake based build system for expat which is attached. Please have a look and say if you would add it to your repository.
regards,
Patrick


----------------------------------------------------------------------

>Comment By: Karl Waclawek (kwaclaw)
Date: 2012-03-05 06:46

Message:
Added CMake build files updated by author to repository. This also
satisfies patch submission #3312568.

----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2012-03-04 15:54

Message:
To make it simple:
Just e-mail me the new files and the patch to MANIFEST, and I will do the
rest in CVS. My e-mail is karl  at waclawek.net .

I assume your files go into the root directory.

----------------------------------------------------------------------

Comment By: Patrick Spendrin (pspe2)
Date: 2012-03-04 15:47

Message:
Ok, I updated the old patch with a readme file:
http://paste.kde.org/~windows/433496/raw/
and I made a new patch with just the changes to MANIFEST:
http://paste.kde.org/~windows/433502/
Also, I cannot do cvs add locally, is this expected?

----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2012-03-04 15:21

Message:
The files to include in the distribution archive should be listed in the
MANIFEST file. With the standard build not everything is included (for
instance, buildconf.sh is not distributed).

----------------------------------------------------------------------

Comment By: Patrick Spendrin (pspe2)
Date: 2012-03-04 15:11

Message:
hm, obviously those files need to be distributed as well, I just don't know
how to bring the make-release.sh script to include them - I will try that
out in a minute.
I also forgot to add a CMake.README file, so I will update the patch again,
but that might have to wait until tomorrow (if that is ok for you).
Just in general, building with cmake should be as easy as 'mkdir build &&
cd build && cmake .. && make && make install' (you run the build process in
the subdirectory build)

----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2012-03-04 14:15

Message:
So, is this all that's needed? 

I know nothing about CMake, so I don't even know if the fact that the
make-release.sh script won't include your files in the tar.gz archive
matters or not.

If you need this included there as well, please update the patch
accordingly.

Thanks,

Karl

----------------------------------------------------------------------

Comment By: Patrick Spendrin (pspe2)
Date: 2012-03-04 13:53

Message:
Sorry, had a hdd crash yesterday, so I had to use a different username and
cannot add files here anymore :-(
Please download an updated patch from here:
http://paste.kde.org/~windows/433382/raw/ 
I found another person having made a similar patch (in the lua project),
but it is essentially the same license & code. I would really love to see
this patch upstream, so thank you very much.

----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2012-03-03 15:10

Message:
Seems non-intrusive. If you can update it for current CVS HEAD (release
2.1.0 being prepared), I'll consider it for inclusion.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=2990652&group_id=10127