[Idle-dev] cleanups

Neal Norwitz neal@metaslash.com
Sat, 30 Nov 2002 14:32:55 -0500


I've tried to make sure everything checked into python was also in
idlefork.  I've also run pychecker which resulted in some additional
checkins.  There are still problems, though.  The most serious ones
are listed below.

There's lots of style issues that should be cleaned up.
Is there a preference who is to do this and when?
I've noticed comments and commented out code which should
probably be removed.

Generally, what is the status of idlefork?  Is it fairly stable?
Are there known major problems in particular areas?

Here are some problems:

  * ClassBrowser.py, PathBrowser.py, StackViewer.py cannot work
    - ClassBrowser.main() & PathBrowser.main() both reference 
      PyShell.flist which does not exist
    - StackViewer.get_stack(), self does not exist, see bug 610756
  * Debugger.py, the local variable text does not exist in several
    places.  I believe the patch below fixes this, but I'm not sure.

Neal
--
+++ Debugger.py 30 Nov 2002 19:18:55 -0000
@@ -309,19 +309,19 @@
     def set_breakpoint_here(self, filename, lineno):
         msg = self.idb.set_break(filename, lineno)
         if msg:
-            text.bell()
+            self.pyshell.bell()
             return
 
     def clear_breakpoint_here(self, filename, lineno):
         msg = self.idb.clear_break(filename, lineno)
         if msg:
-            text.bell()
+            self.pyshell.bell()
             return
 
     def clear_file_breaks(self, filename):
         msg = self.idb.clear_all_file_breaks(filename)
         if msg:
-            text.bell()
+            self.pyshell.bell()