[IPython-dev] making pdoc, pdef, and pinfo more generally useful (Was Re: Patches to use pydb instead of pdb for debugging)

[Hans Meine]

On Saturday 14 October 2006 08:42, Ville M. Vainio wrote:
> The previous bug was fixed by this:
>
>      def new_do_quit(self, arg):
> -        __IPYTHON__.Completer.all_completions=self.old_all_completions
> +
> +        if hasattr(self, 'all_completions'):
> +            __IPYTHON__.Completer.all_completions=self.old_all_completions
>          return OldPdb.do_quit(self, arg)
>
> (it was AttributeError - there was no old_all_completions. Also see
> whether there is a cleaner fix).

Then why don't you check for "old_all_completions" but for "all_completions"?
If that's an actual "svn diff" output I would think this fix is not necessary, 
since it cannot have fixed that problem. ;-p

Greetings,
  Hans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/ipython-dev/attachments/20061014/ec6801ca/attachment.sig>