[IPython-dev] Bug? in cocoa_frontend
ellisonbg.net at gmail.com
Tue Jun 24 18:41:50 EDT 2008
We have actually talked about establishing a slightly formal code
review policy. I too like the idea. While I think rietveld looks
very nice, launchpad recently add some features that basically let you
do code review on launchpad. I have tried this out (OK, I just
"reviewed" my own branch) and it worked rather well and is very well
integrated with everything else we are doing with launchpad/bzr. I
encourage others to have a look at these launchpad capabilities and
see if they think they would help us. If I remember correctly, if you
click on a branches "propose for merging" link, you can 1) provide
comments about the branch and 2) vote in merging.
Simple, but probably enough for what we need.
On Tue, Jun 24, 2008 at 4:25 PM, Barry Wark <barrywark at gmail.com> wrote:
> On Tue, Jun 24, 2008 at 3:11 PM, Gael Varoquaux
> <gael.varoquaux at normalesup.org> wrote:
>> On Tue, Jun 24, 2008 at 03:08:58PM -0700, Barry Wark wrote:
>>> No, you're absolutely right. It should be
>>> currentIndent = len(lines[-1]) - len(lines[-1].lstrip())
>> OK, now I understand what it is supposed to do. Thanks (PS; code review
>> rocks !).
> I agree. That's why I wanted a review ;) I'm cc'ing this to
> ipython-dev to propose that we set up a code review tool for IPython.
> GvR's rietveld (http://code.google.com/appengine/articles/rietveld.html)
> seems like an option, as does http://review-board.org/. I don't think
> either tool works natively with bzr, but it might be worth looking
> I know we're not looking for a rigid code-review process, but an easy
> code review tool couldn't hurt... just a thought.
> IPython-dev mailing list
> IPython-dev at scipy.org
More information about the IPython-dev