[IPython-dev] Closing in on 0.11? We need some review/feedback help

[Fernando Perez]

Hi,

It looks like we crossed emails :)

On Wed, Jan 13, 2010 at 8:36 AM, Mikhail Terekhov <termim at gmail.com> wrote:

> I didn't notice that the failures above are in the IPython-0.10
> installed system wide.

Yup :)

> That means that I tested the wrong version. Probably the instructions
> for testing
> should be modified or may be the iptest script could be modified to
> take care of setting
> PYTHONPATH correctly?  So, to be sure, I uninstalled 0.10 and rerun the tests.
> Obviously I have to set PYTHONPATH manually to do that:

Either that or you have to install this download in full, so it's findable.

But yes, I need to make those instructions clearer, this is now:

https://bugs.launchpad.net/ipython/+bug/507078

> PYTHONPATH=/home/terekhov/python/ipython/ipython-0.11.bzr.r1321 ./iptest
>
> and get:
> ....
> *****************************************************************************
> Ran 10 test groups in 35.004s
>
> ERROR - 1 out of 10 test groups failed.
> ----------------------------------------
> Runner failed: IPython.core
> You may wish to rerun this one individually, with:
> python /home/terekhov/python/ipython/ipython-0.11.bzr.r1321/IPython/scripts/iptest
> -v IPython.core

Great.  This is actually pretty good...

> As suggested  I hen run:
>
> PYTHONPATH=/home/terekhov/python/ipython/ipython-0.11.bzr.r1321
> ./iptest -v IPython.core
>
> and get:
> ...
>
> ======================================================================
> FAIL: Test that object's __del__ methods are called on exit.
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>  File "/usr/lib64/python2.5/site-packages/nose/case.py", line 183, in runTest
>    self.test(*self.arg)
>  File "/home/terekhov/python/ipython/ipython-0.11.bzr.r1321/IPython/testing/decorators.py",
> line 225, in skipper_func
>    return f(*args, **kwargs)
>  File "/home/terekhov/python/ipython/ipython-0.11.bzr.r1321/IPython/core/tests/test_run.py",
> line 160, in test_obj_del
>    tt.ipexec_validate(self.fname, 'object A deleted')
>  File "/home/terekhov/python/ipython/ipython-0.11.bzr.r1321/IPython/testing/tools.py",
> line 288, in ipexec_validate
>    nt.assert_equals(out.strip(), expected_out.strip())
> AssertionError: '\x1b[?1034hobject A deleted' != 'object A deleted'
>>>  raise self.failureException, \
>          (None or '%r != %r' % ('\x1b[?1034hobject A deleted',
> 'object A deleted'))
>
>
> ======================================================================
> FAIL: IPython.core.tests.test_run.TestMagicRunSimple.test_tclass
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>  File "/usr/lib64/python2.5/site-packages/nose/case.py", line 183, in runTest
>    self.test(*self.arg)
>  File "/home/terekhov/python/ipython/ipython-0.11.bzr.r1321/IPython/testing/decorators.py",
> line 225, in skipper_func
>    return f(*args, **kwargs)
>  File "/home/terekhov/python/ipython/ipython-0.11.bzr.r1321/IPython/core/tests/test_run.py",
> line 174, in test_tclass
>    tt.ipexec_validate(self.fname, out)
>  File "/home/terekhov/python/ipython/ipython-0.11.bzr.r1321/IPython/testing/tools.py",
> line 288, in ipexec_validate
>    nt.assert_equals(out.strip(), expected_out.strip())
> AssertionError: "\x1b[?1034hARGV 1-: ['C-first']\nARGV 1-:
> ['C-second']\ntclass.py: deleting object: C-first" != "ARGV 1-:
> ['C-first']\nARGV 1-: ['C-second']\ntclass.py: deleting object:
> C-first"
>>>  raise self.failureException, \
>          (None or '%r != %r' % ("\x1b[?1034hARGV 1-:
> ['C-first']\nARGV 1-: ['C-second']\ntclass.py: deleting object:
> C-first", "ARGV 1-: ['C-first']\nARGV 1-: ['C-second']\ntclass.py:
> deleting object: C-first"))
>
>
> ----------------------------------------------------------------------
> Ran 94 tests in 1.301s
>
> FAILED (SKIP=1, failures=2)
>
> BTW a lot of debugging noise is printed to stdout during the tests
> which somewhat masks
> the real errors.

Yes, unfortunately I'm not sure how to improve that yet...  I don't
quite know where it's coming from, and with all the stdout black magic
that doctest does (this isn't nose's fault, it's doctest itself), it's
really hard to control stdout.

> Out of curiosity I've run:
>
> PYTHONPATH=/home/terekhov/python/ipython/ipython-0.11.bzr.r1321 ./iptest -v
>
>  (notice the '-v') and got two more failures! I.e. 'iptest' and
> 'iptest -v' give different number of failures:

Ignore 'iptest -v' by itself, that's a bug now:

https://bugs.launchpad.net/ipython/+bug/507079

Basically what's reliable is

./iptest   # no other options

or

./iptest [any nose option] IPython.something

But I need to fix that, thanks a lot for your feedback!

Cheers,

f