[IPython-dev] Shutdown __del__ methods bug

[Thomas Kluyver]

On 22 October 2010 09:08, Fernando Perez <fperez.net at gmail.com> wrote:

> do you have any idea why that commit would have reverted those changes?
>  That commit:
>
>
> http://github.com/ipython/ipython/commit/239d2ed6f44c3f6511ee1e9069a5a1aee9c20f9c
>
> appears as a simple merge commit
>

A couple of other things strike me about it:
- In the ipython network graph on github, it doesn't show up as a merge
(there's no other branch leading into it). You have to scroll back a bit now
to see it, but it's the first in a cluster of three commits on trunk just
before the number 11 on the date line.
- Other merges usually mention branches in the commit message. This one just
mentions a file.

Perhaps Min can shed more light, if he remembers how he made the commit. It
does seem that something didn't go to plan. I've noticed a few places where
it's reverting to older forms of code (e.g. using exceptions.Exception), and
I've been tidying them up in my cleanup-old-code branch. I'll put in a pull
request.

If you're worried about possible regressions, I think the best thing is for
you and Min to go over the diff for that commit and work out which changes
were intentional.

Thanks,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/ipython-dev/attachments/20101022/85be1843/attachment.html>