[IPython-dev] Policy for closing pull requests

Brian Granger ellisonbg at gmail.com
Sat Aug 11 21:46:32 EDT 2012


Ondrej has been going through the sympy pull request queue (they have
53 open, but had more than 70) and trying to close ones that are no
longer active.  This as inspired me to think about these issues for
IPython.  I am wondering if we can come up with a policy for closing
pull requests.  Here is what I am thinking.

* Let's use use pull requests for code that is actively being worked
on and reviewed and that has a strong chance of being merged soon.
* Open PRs should be in one of two states: waiting for review or
waiting for additional code.  It should be obvious who the "person of
next action" is.
* When a PR is not in one of these states, it should be closed.
* When a PR is in one of these states, but sits untouched for a long
period of time, we close it and indicate in a comment what would need
to be done to reopen it.

In some rare cases we will outright reject a PR.  But in many cases,
we will close PRs with a fairly positive statement like "this is
promising, please reopen this PR after you do ..."  This is similar to
the to "Someday/Maybe" category of Getting Things Done.

I think this would help us keep our PR/review workflow moving and
encourage people to revisit PRs that are inactive.




Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger at calpoly.edu and ellisonbg at gmail.com

More information about the IPython-dev mailing list