[IPython-dev] tabs for worksheets

[Dennis Sun]

Thanks for the suggestions -- I'll take a look at them when I get home.

I made the mistake of not forking iPython before starting my work (I was
just working from a local copy of main iPython repo). But then in order to
make a pull request, I forked iPython on my github account and pulled this
updated version to my local copy. Then I fumbled around with git for a
while before getting to its present state. Anyway, long story short, I
don't have a complete copy of my code before the merger anymore, so I have
no way to compare the code before and after the merger. (One of these days
I will have to learn to use git....)

If anyone is brave enough to take a look at the code, it's at
http://www.github.com/dlsun/ipython under the "tabs" branch. I would
recommend ignoring the individual commits, which are a mess, and just
looking at the most recent version. I only changed a couple files in
static/js, static/css, and templates. You can even try running the
notebook; the tabs should even be working, even if you can't type anything
into the cells.

I'd really appreciate it if you let me know of any issues that you see.

Thanks,
Dennis

On Mon, Jul 16, 2012 at 8:51 AM, Brian Granger <ellisonbg at gmail.com> wrote:

> One thing you have to be aware of is that the refresh method of the
> CodeMirror instance of each cell has to be called after a cell has
> been unhidden.  This logic should probably be put into a
> Worksheet.refresh_code_mirror method that calls that for all of the
> cells.  It might be that.
>
> Cheers,
>
> Brian
>
> On Mon, Jul 16, 2012 at 12:50 AM, Dennis Sun <dlsun at stanford.edu> wrote:
> > Hi all,
> >
> > I've spent the past week implementing tabs for worksheets, and I managed
> to
> > get it up and running, but the code broke as soon as I merged with master
> > (the merge went through without any conflicts). Specifically, I can't
> type
> > anything into the cells anymore; when I press any key, the cursor
> > disappears. I'm thinking this has something to do with codemirror.
> >
> > The version I was working from was effectively the 0.13 release; is
> anybody
> > aware of any changes that have been made since that might cause this
> > behavior? I've spent the night troubleshooting and can't seem to figure
> it
> > out....
> >
> > Thanks,
> > Dennis
> >
> > _______________________________________________
> > IPython-dev mailing list
> > IPython-dev at scipy.org
> > http://mail.scipy.org/mailman/listinfo/ipython-dev
> >
>
>
>
> --
> Brian E. Granger
> Cal Poly State University, San Luis Obispo
> bgranger at calpoly.edu and ellisonbg at gmail.com
> _______________________________________________
> IPython-dev mailing list
> IPython-dev at scipy.org
> http://mail.scipy.org/mailman/listinfo/ipython-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/ipython-dev/attachments/20120716/4e96ff4e/attachment.html>