[IPython-dev] Cython magics crashes test suite when cython not present
Fernando Perez
fperez.net at gmail.com
Thu May 31 13:21:44 EDT 2012
On Thu, May 31, 2012 at 10:04 AM, MinRK <benjaminrk at gmail.com> wrote:
> I apologize if this is obvious, but are we aware that the test_cythonmagic
> file is *not* excluded in master?
>
> if not have['cython']:
> exclusions.extend([ipjoin('extensions', 'cythonmagic')])
>
> should be:
>
> if not have['cython']:
> exclusions.extend([ipjoin('extensions', 'cythonmagic')])
> exclusions.extend([ipjoin('extensions', 'tests',
> 'test_cythonmagic')])
>
> With this addition, and a manually disabled Cython, testing works fine for
> me.
Yes, I'd noticed that, but in my local testing I still get the problem
even with that fix.
In fact, this is what I have:
if not have['cython']:
exclusions.extend([ipjoin('extensions', 'cythonmagic')])
exclusions.extend([ipjoin('extensions', 'cythonmagic.py')])
exclusions.extend([ipjoin('extensions', 'test', 'test_cythonmagic')])
exclusions.extend([ipjoin('extensions', 'test', 'test_cythonmagic.py')])
ARGGHHH!!! Nevermind, I fixed the exclusions list with 'test' not
'tests' as the subdir. I'm a moron.
f
More information about the IPython-dev
mailing list