[IPython-dev] submodules over https

Aron Ahmadia aron at ahmadia.net
Thu May 2 14:05:11 EDT 2013


Brian,

>From what I understand of the intentions for the component submodule (most
pull requests will not touch it), I think you're correct.

*Even forcing people to do "git submodule init && git
submodule update" adds friction.*
*
*
Tell them to do:

git clone --recursive ipython/ipython # this does the submodule init/update
bits for you

Submodules add an unfriendly level of complexity, but it turns out that
version control is a hard problem :/

A



On Thu, May 2, 2013 at 7:00 PM, Brian Granger <ellisonbg at gmail.com> wrote:

> I don't think using relative submodule urls is a good idea.  A common
> GitHub work flow when people start the contribute to a project is:
>
> 1, Fork ipython/ipython
> 2. Create a local clone of username/ipython
> 3. Branch and push to username/ipython
> 4. Create a PR
>
> This completely common workflow would require new devs to muck with
> the submodule url or also fork our submodules.  I don't see that as
> acceptable as we want to minimize the friction for new people to
> contribute.  Even forcing people to do "git submodule init && git
> submodule update" adds friction.
>
> So unless I am misunderstanding somethign, I am -1 on relative urls.
>
> Cheers,
>
> Brian
>
> On Thu, May 2, 2013 at 10:48 AM, MinRK <benjaminrk at gmail.com> wrote:
> > Maybe I am overestimating how many users actually want IPython to be
> > installable from their own fork, rather than only ever being valid after
> > merging into master.  I don't mean to say that maintaining separate
> > `components` is difficult, but it is tedious and unintuitive.
> >
> > Let's give relative URL a shot for now, and revisit the issue if there
> are
> > actual problems (not counting the one I ran into when trying to write
> > exactly this PR).
> >
> >
> > On Thu, May 2, 2013 at 10:42 AM, W. Trevor King <wking at tremily.us>
> wrote:
> >>
> >> On Thu, May 02, 2013 at 06:15:11PM +0100, Aron Ahmadia wrote:
> >> > Just wanted to point out that I found out how to use submodules from
> >> > your pull request to pycuda.  Thanks!
> >>
> >> Glad to help :).
> >>
> >> On Thu, May 02, 2013 at 10:28:51AM -0700, MinRK wrote:
> >> > Mirroring is a better case, since it shouldn't actually affect the
> >> > repo.  But it seems pretty terrible that under normal circumstances,
> >> > no clone of any IPython repo other than the official one or a proper
> >> > careful mirror will actually be functional.
> >>
> >> I think “proper careful mirror” is a bit alarmist ;).  If it's just a
> >> single level of submodules (and it's currently just a single
> >> `components` submodule), all you have to do is mirror the submodules
> >> at the same place.  For me:
> >>
> >>   $ cd /var/git
> >>   $ git clone git://github.com/ipython/ipython.git
> >>   $ git clone git://github.com/ipython/ipython-components.git
> >>
> >> Working mirror complete ;).
> >>
> >> Cheers,
> >> Trevor
> >>
> >> --
> >> This email may be signed or encrypted with GnuPG (http://www.gnupg.org
> ).
> >> For more information, see
> http://en.wikipedia.org/wiki/Pretty_Good_Privacy
> >>
> >> _______________________________________________
> >> IPython-dev mailing list
> >> IPython-dev at scipy.org
> >> http://mail.scipy.org/mailman/listinfo/ipython-dev
> >>
> >
> >
> > _______________________________________________
> > IPython-dev mailing list
> > IPython-dev at scipy.org
> > http://mail.scipy.org/mailman/listinfo/ipython-dev
> >
>
>
>
> --
> Brian E. Granger
> Cal Poly State University, San Luis Obispo
> bgranger at calpoly.edu and ellisonbg at gmail.com
> _______________________________________________
> IPython-dev mailing list
> IPython-dev at scipy.org
> http://mail.scipy.org/mailman/listinfo/ipython-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/ipython-dev/attachments/20130502/919bd7f0/attachment-0001.html>


More information about the IPython-dev mailing list