[IPython-dev] Where should bugfix PRs go, and how would I include a javascript fix in my package?
Matt Craig
mattwcraig at gmail.com
Sun Aug 2 23:30:33 EDT 2015
Hi,
A couple of questions:
1. I've got a fix to a couple of issues that come up when
Accordion widgets are nested. I've read the contributing guide on
github and am wondering whether I should make the PR on master in
ipython/ipython (since the issue occurs in ipython 3.2) or in
ipython/ipywidgets (since that is the Future)?
2. In a nutshell, the fixes, in the javascript for AccordionView, ensure
that titles and show/hide events are not propagated to Accordions that are
children of an Accordion. I'd like to include this fix in the package I'm
using the Accordions in (reducer <https://github.com/mwcraig/reducer>). I'm
fine with creating a custom Accordion python class that is used instead
of the ipython Accordion if the user is using a version of ipytohn that
doesn't contain the fix in 1.
My question: How do I connect my python accordion to my modified version
of the javascript AccordionView?
To be clear, I'm already distributing this as a python package on pypi.
Also, I went to the advanced jupyter tutorial at SciPy 2015, so
if the answer is I should go back and read hose materials more closely,
just tell me :).
Matt Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/ipython-dev/attachments/20150802/5cd61f88/attachment.html>
More information about the IPython-dev
mailing list