[Ironpython-users] Patch

[Slide]

I'll update the GlobalAssemblyCache check before pushing.

On Thu, Feb 23, 2012 at 11:16 PM, Dino Viehland <dinov at microsoft.com> wrote:

>  This is awesome, a couple comments:****
>
>                 Can AssemblyResolve be moved into PythonOps?  It looks
> like it keys off of Assembly.GetEntryAssembly() and so doesn’t rely on
> anything in the generated assembly.  That’d make it easier to read and
> update the code.  Maybe I missed something that depends upon the assembly,
> but if that’s the case the assembly could be passed into a class which has
> the AssemblyResolve method.****
>
> ** **
>
>                 I think the GlobalAssemblyCache check is too strong.  Ipy
> install via the MSI will go into the GAC and so I think it won’t be
> embedded.  This should probably exclude the known Ipy/Dlr assemblies from
> the GAC check.****
>
> ** **
>
> +1 on what Jeff said as well, I’d just add an overload instead of doing
> the default value thing.  ****
>
> ** **
>
> Now I’m going to have to think more about pyc support for PTVS.****
>
> ** **
>
> *From:* ironpython-users-bounces+dinov=microsoft.com at python.org [mailto:
> ironpython-users-bounces+dinov=microsoft.com at python.org] *On Behalf Of *
> Slide
> *Sent:* Thursday, February 23, 2012 7:55 PM
> *To:* ironpython-users at python.org
> *Subject:* [Ironpython-users] Patch****
>
> ** **
>
> Just wanted to get this out for review before I push it. I would have done
> it through my fork on github and issued a pull request, but my fork is
> currently messed up. Let me know if you see anything out of the ordinary.*
> ***
>
> ** **
>
> Fixes 32288 and 26706****
>
> ** **
>
> Thanks,****
>
> ** **
>
> slide****
>
> ** **
>
>
> ****
>
> ** **
>
> --
> Website: http://earl-of-code.com****
>



-- 
Website: http://earl-of-code.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/ironpython-users/attachments/20120224/718e63f5/attachment.html>