[ mailman-Bugs-669081 ] Major attachment handling bug!
SourceForge.net
noreply at sourceforge.net
Sun Jan 19 18:11:24 EST 2003
Bugs item #669081, was opened at 2003-01-16 09:46
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=669081&group_id=103
Category: Pipermail
Group: 2.1 (stable)
Status: Open
Resolution: None
Priority: 9
Submitted By: Daniel Buchmann (avalon)
Assigned to: Barry A. Warsaw (bwarsaw)
Summary: Major attachment handling bug!
Initial Comment:
Attachments are not handled correctly.
Attached to this bug report is an example email in a mbox file.
How to reproduce:
1. create a list called "clasohlson"
2. copy this mbox file to the archive mbox file
3. run bin/arch for the list
4. look at the resulting archive
I will post a followup which will contain the resulting html file I got when
doing this.
----------------------------------------------------------------------
>Comment By: Barry A. Warsaw (bwarsaw)
Date: 2003-01-19 21:11
Message:
Logged In: YES
user_id=12800
Ok, try the attached. I haven't checked the private cgi
yet, but I'm sure that's an unrelated problem. This fixes
all the other issues.
----------------------------------------------------------------------
Comment By: Barry A. Warsaw (bwarsaw)
Date: 2003-01-19 20:41
Message:
Logged In: YES
user_id=12800
Ok, attachment_error.mbox was shallow. I'll have a fix for
that too.
----------------------------------------------------------------------
Comment By: Barry A. Warsaw (bwarsaw)
Date: 2003-01-19 20:37
Message:
Logged In: YES
user_id=12800
TK, I've looked at the patch, and I like parts of it but not
other parts. For me, get_content_charset() always digs out
the right character set without the need for that regexp.
If it doesn't for you, then that's a bug in the email
package, which we should report and fix.
I've attached my tentative patch which seems to fix the
clasohlson mbox when using Czech. I haven't yet tried
attachment_error.mbox, and I haven't fixed the private
archiver or the mimetypes lie, but will get to those next.
----------------------------------------------------------------------
Comment By: Jan Siml (janjules)
Date: 2003-01-19 09:45
Message:
Logged In: YES
user_id=151422
After applying the patch it still doesn't work. I deleted the directory of the
archive and rebuild the archive by using bin/arch. But even now, i got the
same: no attachment, only
")Ãj×¢jxZ¢´§Öz|.× zÇ!ç]z»Cj×¢?©Ê<óuA"±È^". Did i
forget anything to do?
----------------------------------------------------------------------
Comment By: Daniel Buchmann (avalon)
Date: 2003-01-19 08:18
Message:
Logged In: YES
user_id=184577
Applied cleanly, and now there is only one problem left! :D
I believe Mailman is supplying the wrong MIME type for the .doc file when
the archive is private. Thus, the webbrowser just displays the raw file
instead of launching an application that can handle it correctly. I changed
the archive to public, and the file was displayed correctly.
Thanks for your quick fix so far, this has really helped a lot! (The users of
the particular list were depending heavily on the archive for the list, and
considered the list completely unuseable without attachments available in
the archive.)
----------------------------------------------------------------------
Comment By: Tokio Kikuchi (tkikuchi)
Date: 2003-01-18 19:57
Message:
Logged In: YES
user_id=67709
I have updated the patch. Please try.
(Patch ID 670167)
----------------------------------------------------------------------
Comment By: Daniel Buchmann (avalon)
Date: 2003-01-18 11:54
Message:
Logged In: YES
user_id=184577
Sorry, forget my last comment, the attachment was just fine. My mistake.
But attachment naming is still a problem.
----------------------------------------------------------------------
Comment By: Daniel Buchmann (avalon)
Date: 2003-01-18 11:49
Message:
Logged In: YES
user_id=184577
Check also the attached "attachment_error.mbox". It contains a single message,
with a MS Word document that becomes completely scrambled after going
through pipermail...
----------------------------------------------------------------------
Comment By: Daniel Buchmann (avalon)
Date: 2003-01-18 11:18
Message:
Logged In: YES
user_id=184577
Applied without problems, but gave me the following error when running
bin/arch (not on the mbox I submitted, though):
Traceback (most recent call last):
File "bin/arch", line 187, in ?
main()
File "bin/arch", line 175, in main
archiver.processUnixMailbox(fp, start, end)
File "/home/mailman/Mailman/Archiver/pipermail.py", line 544, in
processUnixMailbox
m = mbox.next()
File "/usr/lib/python2.2/mailbox.py", line 33, in next
return self.factory(_Subfile(self.fp, start, stop))
File "/home/mailman/Mailman/Mailbox.py", line 79, in scrubber
return mailbox.scrub(msg)
File "/home/mailman/Mailman/Mailbox.py", line 99, in scrub
return self._scrubber(self._mlist, msg)
File "/home/mailman/Mailman/Handlers/Scrubber.py", line 145, in process
cs = csre.search(part['content-type'])
TypeError: expected string or buffer
The offending message had no "Content-Type:" field in its header. (It was,
of course, produced by a Microsoft product... ;)
Some issues from my earlier subimtted example that still needs to be fixed:
1. The attachment file name still becomes ".dot", not ".doc" as it should
have been. Also, the reported size is wrong (larger) than the actual file.
2. "The attachment was scrubbed" part in the archive web page is still sort
of "attached" to the message itself, e.g. to the email signature of the user
that posted the message.
----------------------------------------------------------------------
Comment By: Tokio Kikuchi (tkikuchi)
Date: 2003-01-18 01:03
Message:
Logged In: YES
user_id=67709
Please try this patch.
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=670167&group_id=103
(Patch ID 670167)
----------------------------------------------------------------------
Comment By: Daniel Buchmann (avalon)
Date: 2003-01-16 11:29
Message:
Logged In: YES
user_id=184577
-changing priority and assignment-
----------------------------------------------------------------------
Comment By: Daniel Buchmann (avalon)
Date: 2003-01-16 10:31
Message:
Logged In: YES
user_id=184577
And here is the html file in english. Notice the difference. Lots of garbage (also
called mojibake?)
;)
----------------------------------------------------------------------
Comment By: Daniel Buchmann (avalon)
Date: 2003-01-16 10:28
Message:
Logged In: YES
user_id=184577
Here is the generated html page for the email, if list language is set to
norwegian.
----------------------------------------------------------------------
Comment By: Daniel Buchmann (avalon)
Date: 2003-01-16 10:26
Message:
Logged In: YES
user_id=184577
Sorry, my web browser hung after submitting the bug, and I had to go offfline
in a hurry. Trying again.... :)
----------------------------------------------------------------------
Comment By: Barry A. Warsaw (bwarsaw)
Date: 2003-01-16 10:07
Message:
Logged In: YES
user_id=12800
There was no attachment, are you sure you clicked the
checkbox? :(
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=669081&group_id=103
More information about the Mailman-coders
mailing list