[ mailman-Patches-683906 ] Makefile: add $DESTDIR to install target

[SourceForge.net]

Patches item #683906, was opened at 2003-02-10 14:21
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=683906&group_id=103

Category: configure/install
Group: Mailman 2.1
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Ademar de Souza Reis Jr (ade_br)
>Assigned to: Thomas Wouters (twouters)
Summary: Makefile: add $DESTDIR to install target

Initial Comment:
This patch adds a DESTDIR variable for the install
target. It's really useful for people packaging
mailman, since they (we) can install it in an empty
directory.

If DESTDIR is not defined, this patch is harmless (/ is
used, as expected).

Please apply. :-)
   - Ademar <ademar [A T] conectiva.com.br>

----------------------------------------------------------------------

>Comment By: Thomas Wouters (twouters)
Date: 2003-03-11 01:46

Message:
Logged In: YES 
user_id=34209

Thanks... I checked in a slightly altered version (stop
bin/update from running, fix some left-out $(DESTDIR)s, fix
some whitespace.) If you use this patch yourself, you
probably want to grab a diff from CVS instead.


----------------------------------------------------------------------

Comment By: Ademar de Souza Reis Jr (ade_br)
Date: 2003-03-10 15:47

Message:
Logged In: YES 
user_id=184557

You're probably right. I don't remember why I choosed that
approach.

----------------------------------------------------------------------

Comment By: Thomas Wouters (twouters)
Date: 2003-03-10 15:28

Message:
Logged In: YES 
user_id=34209

I agree that this is a good thing (I've done my share of
packaging :) but I'm not sure why you're doing this:

cd $(DESTDIR)/; \
$(PYTHON) -c 'from compileall import *;
compile_dir(".$(prefix)/Mailman")'

Especially since it's not in a subshell. Why not just do
compile_dir("$(DESTDIR)$(prefix)/Mailman") ?



----------------------------------------------------------------------

Comment By: Ademar de Souza Reis Jr (ade_br)
Date: 2003-02-10 14:26

Message:
Logged In: YES 
user_id=184557

uploading patch file
(didn't work last time) :(

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=683906&group_id=103