[ mailman-Patches-970383 ] moderator -1 admin requests pending

[SourceForge.net]

Patches item #970383, was opened at 2004-06-10 22:57
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=970383&group_id=103

Category: list administration
Group: Mailman 2.1
Status: Open
Resolution: None
Priority: 5
Submitted By: Jim Tittsler (jtittsler)
Assigned to: Nobody/Anonymous (nobody)
Summary: moderator -1 admin requests pending

Initial Comment:
ListAdmin.NumRequestsPending() presumes that the
request database always has at least one entry... a
dummy "request" containing the version number of the
request database.  bin/newlist does not create a
request database for each list, so the moderator gets a
daily mail saying there are -1 requests pending.

I propose that when __opendb() fails because the file
didn't exist, the version number be added to the __db dict.

Two additional points:
 - perhaps __open_db should ALWAYS add the version to
the db, in case a request.pck somehow was created
without a version key (especially since the version
isn't currently checked)
- the closedb setting of the version could *probably*
be safely removed



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300103&aid=970383&group_id=103