[ mailman-Bugs-1275856 ] Utils.get_domain() wrong if VIRTUAL_HOST_OVERVIEW off

[SourceForge.net]

Bugs item #1275856, was opened at 2005-08-29 10:26
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1275856&group_id=103

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Web/CGI
Group: 2.1 (stable)
Status: Open
Resolution: None
Priority: 5
Submitted By: Mark Sapiro (msapiro)
Assigned to: Nobody/Anonymous (nobody)
Summary: Utils.get_domain() wrong if VIRTUAL_HOST_OVERVIEW off

Initial Comment:
Part of the code in get_domain() in Utils.py is:

    if mm_cfg.VIRTUAL_HOST_OVERVIEW and host:
        return host.lower()
    else:
        # See the note in Defaults.py concerning
DEFAULT_HOST_NAME
        # vs. DEFAULT_EMAIL_HOST.
        hostname = mm_cfg.DEFAULT_HOST_NAME or
mm_cfg.DEFAULT_EMAIL_HOST
        return hostname.lower()

It is clear that get_domain() should return the web
host, not the e-mail host. This code should be:

    if mm_cfg.VIRTUAL_HOST_OVERVIEW and host:
        return host.lower()
    else:
        # See the note in Defaults.py concerning
DEFAULT_URL
        # vs. DEFAULT_URL_HOST.
        hostname = mm_cfg.DEFAULT_URL or
mm_cfg.DEFAULT_URL_HOST
        return hostname.lower()


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1275856&group_id=103