[ mailman-Bugs-1531675 ] ARCHIVE_TO_MBOX=1 broken

[SourceForge.net]

Bugs item #1531675, was opened at 2006-07-31 04:23
Message generated for change (Comment added) made by msapiro
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1531675&group_id=103

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: configuring/installing
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Ross Golder (rossigee)
Assigned to: Nobody/Anonymous (nobody)
Summary: ARCHIVE_TO_MBOX=1 broken

Initial Comment:
While looking into an archiving problem on
mail.gnome.org, where we use our own external archiver
(ARCHIVE_TO_MBOX was set to 1), Owen Taylor discovered
the following bug causing it to ignore this setting:

>From /usr/lib/mailman/Mailman/Defaults.py:

# ARCHIVE_TO_MBOX
#-1 - do not do any archiving
# 0 - do not archive to mbox, use builtin mailman html
archiving only
# 1 - archive to mbox to use an external archiving
mechanism only
# 2 - archive to both mbox and builtin mailman html
archiving -
#     use this to make both external archiving
mechanism work and
#     mailman's builtin html archiving.  the flat mail
file can be
#     useful for searching, external archivers, etc.
ARCHIVE_TO_MBOX = 2

Now, while that's not particularly clear, I can
certainly see why one might assume that we wanted a
setting, of '1', but if you look at the code we see:

        if mm_cfg.ARCHIVE_TO_MBOX in (1, 2):
            self.__archive_to_mbox(msg)
            if mm_cfg.ARCHIVE_TO_MBOX == 1:
                # Archive to mbox only.
                return
        txt = str(msg)
        # should we use the internal or external archiver?
        [...]

So, ARCHIVE_TO_MBOX=1 skips both the internal *and*
external archivers, and archives only to the MBOX files.


----------------------------------------------------------------------

>Comment By: Mark Sapiro (msapiro)
Date: 2006-07-31 18:51

Message:
Logged In: YES 
user_id=1123998

This really isn't a bug. It is a case of things changing and
the documentation not keeping pace. (What's the difference
between a bug and an error? - A bug is fixed by changing the
code; an error is fixed by changing the documentation.)

The misleading part is:

# 1 - archive to mbox to use an external archiving mechanism
only.

This should really say:

# 1 - archive to mbox only

The PUBLIC_EXTERNAL_ARCHIVER and PRIVATE_EXTERNAL_ARCHIVER
settings were added significantly after the ARCHIVE_TO_MBOX
setting. Prior to this, 'external archivers' had to read the
.mbox file which is why the setting of '1' was described as
it was.

I've changed the descriptions in the Subversion trunk.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1531675&group_id=103