[ mailman-Bugs-1000699 ] moderator page with details misses a submit button

[SourceForge.net]

Bugs item #1000699, was opened at 2004-07-30 06:30
Message generated for change (Comment added) made by msapiro
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1000699&group_id=103

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Web/CGI
Group: 2.1 (stable)
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Stepan Kasal (kasal)
Assigned to: Nobody/Anonymous (nobody)
Summary: moderator page with details misses a submit button

Initial Comment:
Working with version 2.1.5.

I moderate a few lists.  When I go from summary page to
"wiev the detail of individual postings", I get a page
which has a submit button at the bottom.

Similar button should be on the top, as with the
Summary page.

Besides being an inconvenience, this can also be confusing:
I checked "Discard all msgs marked as deferred" on the top,
then moved to the end and pressed the button there.
Of course the upper checkbox had no influence.

Btw: I hope that the "discard all deferred" checkbox
discards only the messages from that dispayed page, not
the messages that might have arrived while themoderator
was staring at the page.
That would be nasty if it weren't this way.


----------------------------------------------------------------------

>Comment By: Mark Sapiro (msapiro)
Date: 2006-01-30 07:21

Message:
Logged In: YES 
user_id=1123998

I am marking this closed/fixed because the "discard all
deferred" checkbox was intended to work only on the summary
page. It's appearance on the detail pages was a mistake that
was fixed in 2.1.6.

So yes, in 2.1.5 neither "discard all deferred" checkbox
works on the detail pages, and BTW, you can check the box at
the top of the summary page and click the button at the
bottom or vice versa and it works.

In 2.1.6 and above, the checkboxes appear only on the
summary page and they only cause messages on that page
marked 'defer' to be discarded even if there are other
messages not rendered on that page.

Also, there are submit buttons at both the top and bottom of
both the 'all messages from' detail and the individual
message detail.

If you really want a "discard all messages marked defer" box
that works on the "view all messages from" page, that is now
a feature request (RFE) and should be resubmitted as such.

----------------------------------------------------------------------

Comment By: Dan Astoorian (djast)
Date: 2006-01-30 06:48

Message:
Logged In: YES 
user_id=1437943

The scope of the problem is greater than that: "Discard all
msgs marked as deferred" does not appear to work at all from
the "details" page, as far as I can tell.

In the summary page, each group of items on which an action
is to be taken is identified with a set of radio buttons
with 'INPUT name="senderaction-SENDER"' tags, and the
"senderaction-" prefix is used by the code in Cgi/admindb.py
which processes the "Discard all msgs marked as deferred"
checkbox.

However, the details page uses only the request-id in the
field names, e.g., 'INPUT name="10112"', so they aren't
processed by the same code.  I can't find anywhere else in
the code (Mailman 2.1.7) where the discardalldefersp field
is processed.
 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1000699&group_id=103