[ mailman-Bugs-1660666 ] syntax error in CheckFixUid.py

[SourceForge.net]

Bugs item #1660666, was opened at 2007-02-15 06:39
Message generated for change (Comment added) made by msapiro
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1660666&group_id=103

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: command line scripts
Group: 2.1 (stable)
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Christian Reß (chris_ress)
Assigned to: Nobody/Anonymous (nobody)
Summary: syntax error in CheckFixUid.py

Initial Comment:
bin/CheckFixUid.py is created by bin/check_perms_grsecurity.py. It has a syntax error that keeps mailman from starting up.

Reproducable: always

Steps to reproduce:
1. run bin/check_perms_grsecurity.py -f
2. run bin/mailmanctl start

The error:
NameError: name 'uid' is not defined
Traceback (most recent call last):
  File "/usr/local/mailman/bin/qrunner", line 80, in ?
    import CheckFixUid
  File "/usr/local/mailman/bin/CheckFixUid.py", line 6, in ?
    class CheckFixUid:
  File "/usr/local/mailman/bin/CheckFixUid.py", line 12, in CheckFixUid
    if os.geteuid() != uid:

A proposed fix is attached. 

----------------------------------------------------------------------

>Comment By: Mark Sapiro (msapiro)
Date: 2007-02-15 10:52

Message:
Logged In: YES 
user_id=1123998
Originator: NO

Never Mind!

I was originally looking at my installed Mailman that doesn't include the
contrib directory. I see that it is in the contributed software for which
the README says:
<quote>
This directory contains unofficial contributed scripts and extensions
to Mailman.  They are unsupported by the Mailman developers.  If you
have questions or problems with them, please contact the contribution
author directly.
</quote>

However, since the patch is so simple and obvious, I'll go ahead and patch
it.

----------------------------------------------------------------------

Comment By: Mark Sapiro (msapiro)
Date: 2007-02-15 10:44

Message:
Logged In: YES 
user_id=1123998
Originator: NO

Perhaps I am mistaken. Can you tell me the exact path to where you found
check_perms_grsecurity.py in either the Mailman 2.1.9 tarball or SVN?

----------------------------------------------------------------------

Comment By: Christian Reß (chris_ress)
Date: 2007-02-15 09:10

Message:
Logged In: YES 
user_id=1720190
Originator: YES

Since it is part of the official distribution and is also in you SVN, I
thought you'd like to quickly apply a fix to it.

Anyway, I'll contact the contributor. 

----------------------------------------------------------------------

Comment By: Mark Sapiro (msapiro)
Date: 2007-02-15 09:05

Message:
Logged In: YES 
user_id=1123998
Originator: NO

These are not GNU Mailman scripts. They must be part of some
redistribution. Please report this bug to your packager. There's nothing
the Mailman project can do about it.

----------------------------------------------------------------------

Comment By: Christian Reß (chris_ress)
Date: 2007-02-15 06:40

Message:
Logged In: YES 
user_id=1720190
Originator: YES

I forgot: You need to start Mailman as root for the error to occur.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1660666&group_id=103