[ mailman-Bugs-1966837 ] Subscribing via e-mail fails.

[SourceForge.net]

Bugs item #1966837, was opened at 2008-05-19 10:09
Message generated for change (Comment added) made by berndts
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1966837&group_id=103

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: (un)subscribing
Group: 2.1 (stable)
Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Stephan Berndts (berndts)
Assigned to: Nobody/Anonymous (nobody)
Summary: Subscribing via e-mail fails.

Initial Comment:
Hi,

when I try to subscribe to a mailing list by sending an e-mail to listname-join at listserver this fails with the following error:

May 13 13:08:54 2008 (14270) Uncaught runner exception: 'NoneType' object has no attribute 'lower'
May 13 13:08:54 2008 (14270) Traceback (most recent call last):
  File "/srv/mailman/Mailman/Queue/Runner.py", line 114, in _oneloop
    self._onefile(msg, msgdata)
  File "/srv/mailman/Mailman/Queue/Runner.py", line 185, in _onefile
    keepqueued = self._dispose(mlist, msg, msgdata)
  File "/srv/mailman/Mailman/Queue/CommandRunner.py", line 241, in _dispose
    res.do_command('join')
  File "/srv/mailman/Mailman/Queue/CommandRunner.py", line 139, in do_command
    return handler.process(self, args)
  File "/srv/mailman/Mailman/Commands/cmd_subscribe.py", line 74, in process
    if digest is None and password.lower() in ('digest', 'nodigest'):
AttributeError: 'NoneType' object has no attribute 'lower'

May 13 13:08:54 2008 (14270) SHUNTING: 1210676933.788779+8f3f3d5d13ba53d21c00b3731faff2259213e4bf
M

The error arises as cmd_subscribe.py assumes that the variable "password" is not empty (at line 74) which is not true if neither a password nor an option in {digest,nodigest} was passed as a command-line argument.

A patch resolving the error is attached.

----------------------------------------------------------------------

>Comment By: Stephan Berndts (berndts)
Date: 2008-05-19 21:51

Message:
Logged In: YES 
user_id=129854
Originator: YES

Oops. I actually read it on mailman-announce but forgot about it when I
discovered the bug.
But: I browsed through the bug tracker and could not find the bug there.
Maybe you should open a bug even for bugs you already fixed (and close
them instantly).

----------------------------------------------------------------------

Comment By: Mark Sapiro (msapiro)
Date: 2008-05-19 17:37

Message:
Logged In: YES 
user_id=1123998
Originator: NO

Thanks for the patch.

This is a known issue. See the news item "Important patch for Mailman
2.1.10 2008-04-26" on the project page at
<http://sourceforge.net/projects/mailman> and the Mailman_2.1.10.patch file
on the download page at
<http://sourceforge.net/project/showfiles.php?group_id=103>.

Also see
<http://mail.python.org/pipermail/mailman-announce/2008-April/000111.html>
which was also posted to mailman-developers at python.org and
mailman-users at python.org.

Do you have any suggestions as to how the make things like this more
visible?


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1966837&group_id=103