[Bug 244233] Re: Logrotate is noisy with: Re-opening all log files

[Imre Gergely]

I've updated the bug description with some details for a SRU and I've
tested the patch provided by pearcec and it's working as expected.

** Description changed:

  Binary package hint: mailman
  
  When logrotate runs for mailman you get this:
  
  /etc/cron.daily/logrotate:
  Re-opening all log files
  Re-opening all log files
  
  It calls mailmanctl reopen. If it called it with a -q it would be quiet.
+ 
+ IMPACT: when rotating the mailman logfiles, 'mailmanctl reopen' is called from
+ /etc/logrotate.d/mailman, to get mailman to reopen the new logfiles. For every
+ call, mailman prints message "Re-opening all log files", which gets sent to
+ the user in a (useless) email.
+ 
+ This was fixed upstream in mailman 2.1.9-10 and Karmic has 2.1.12-2.
+ 
+ TEST CASE:
+ 
+ - install mailman (apt-get install mailman)
+ - create the default mailman list with the following command:
+     newlist mailman
+ - start mailman (/etc/init.d/mailman start), there should be a couple of files
+   in /var/log/mailman
+ - force a logrotate of these files by running:
+     logrotate -f /etc/logrotate.d/mailman
+ - you should see the following output:
+ 
+ root at utest-hhs32:/var/log/mailman# logrotate -f /etc/logrotate.d/mailman
+ Re-opening all log files
+ Re-opening all log files
+ 
+ This is called from crontab so there will be an email sent to users
+ every time.
+ 
+ - install the patched version, and run the above command again, it should be
+ quiet, without any messages.
+ 
+ REGRESSION POTENTIAL: low. According to the mailmanctl help page:
+ 
+     -q/--quiet
+       Don't print status messages.  Error messages are still printed to
+       standard error.
+ 
+ By applying this patch, users will not get the informational messages but they
+ will still get any error message.

** Description changed:

  Binary package hint: mailman
  
  When logrotate runs for mailman you get this:
  
  /etc/cron.daily/logrotate:
  Re-opening all log files
  Re-opening all log files
  
  It calls mailmanctl reopen. If it called it with a -q it would be quiet.
  
  IMPACT: when rotating the mailman logfiles, 'mailmanctl reopen' is called from
  /etc/logrotate.d/mailman, to get mailman to reopen the new logfiles. For every
  call, mailman prints message "Re-opening all log files", which gets sent to
  the user in a (useless) email.
  
  This was fixed upstream in mailman 2.1.9-10 and Karmic has 2.1.12-2.
  
  TEST CASE:
  
  - install mailman (apt-get install mailman)
  - create the default mailman list with the following command:
-     newlist mailman
+     newlist mailman
  - start mailman (/etc/init.d/mailman start), there should be a couple of files
-   in /var/log/mailman
+   in /var/log/mailman
  - force a logrotate of these files by running:
-     logrotate -f /etc/logrotate.d/mailman
+     logrotate -f /etc/logrotate.d/mailman
  - you should see the following output:
  
  root at utest-hhs32:/var/log/mailman# logrotate -f /etc/logrotate.d/mailman
  Re-opening all log files
  Re-opening all log files
  
  This is called from crontab so there will be an email sent to users
  every time.
  
  - install the patched version, and run the above command again, it should be
  quiet, without any messages.
  
  REGRESSION POTENTIAL: low. According to the mailmanctl help page:
  
-     -q/--quiet
-       Don't print status messages.  Error messages are still printed to
-       standard error.
+     -q/--quiet
+       Don't print status messages.  Error messages are still printed to
+       standard error.
  
  By applying this patch, users will not get the informational messages but they
  will still get any error message.

** Description changed:

  Binary package hint: mailman
  
  When logrotate runs for mailman you get this:
  
  /etc/cron.daily/logrotate:
  Re-opening all log files
  Re-opening all log files
  
  It calls mailmanctl reopen. If it called it with a -q it would be quiet.
  
- IMPACT: when rotating the mailman logfiles, 'mailmanctl reopen' is called from
- /etc/logrotate.d/mailman, to get mailman to reopen the new logfiles. For every
- call, mailman prints message "Re-opening all log files", which gets sent to
- the user in a (useless) email.
+ IMPACT: when rotating the mailman logfiles, 'mailmanctl reopen' is called
+ from /etc/logrotate.d/mailman, to get mailman to reopen the new logfiles.
+ For every call, mailman prints message "Re-opening all log files", which
+ gets sent to the user in a (useless) email.
  
  This was fixed upstream in mailman 2.1.9-10 and Karmic has 2.1.12-2.
  
  TEST CASE:
  
  - install mailman (apt-get install mailman)
  - create the default mailman list with the following command:
      newlist mailman
- - start mailman (/etc/init.d/mailman start), there should be a couple of files
-   in /var/log/mailman
+ - start mailman (/etc/init.d/mailman start), there should be a couple of
+   files in /var/log/mailman
  - force a logrotate of these files by running:
      logrotate -f /etc/logrotate.d/mailman
  - you should see the following output:
  
  root at utest-hhs32:/var/log/mailman# logrotate -f /etc/logrotate.d/mailman
  Re-opening all log files
  Re-opening all log files
  
- This is called from crontab so there will be an email sent to users
- every time.
+ This is called from crontab so there will be an email sent to users every
+ time.
  
- - install the patched version, and run the above command again, it should be
- quiet, without any messages.
+ - install the patched version, and run the above command again, it should
+ be quiet, without any messages.
  
  REGRESSION POTENTIAL: low. According to the mailmanctl help page:
  
      -q/--quiet
        Don't print status messages.  Error messages are still printed to
        standard error.
  
- By applying this patch, users will not get the informational messages but they
- will still get any error message.
+ By applying this patch, users will not get the informational messages but
+ they will still get any error message.

** Description changed:

  Binary package hint: mailman
  
  When logrotate runs for mailman you get this:
  
  /etc/cron.daily/logrotate:
  Re-opening all log files
  Re-opening all log files
  
  It calls mailmanctl reopen. If it called it with a -q it would be quiet.
  
  IMPACT: when rotating the mailman logfiles, 'mailmanctl reopen' is called
  from /etc/logrotate.d/mailman, to get mailman to reopen the new logfiles.
  For every call, mailman prints message "Re-opening all log files", which
  gets sent to the user in a (useless) email.
  
  This was fixed upstream in mailman 2.1.9-10 and Karmic has 2.1.12-2.
  
  TEST CASE:
  
  - install mailman (apt-get install mailman)
  - create the default mailman list with the following command:
      newlist mailman
  - start mailman (/etc/init.d/mailman start), there should be a couple of
-   files in /var/log/mailman
+   files in /var/log/mailman
  - force a logrotate of these files by running:
      logrotate -f /etc/logrotate.d/mailman
  - you should see the following output:
  
  root at utest-hhs32:/var/log/mailman# logrotate -f /etc/logrotate.d/mailman
  Re-opening all log files
  Re-opening all log files
  
  This is called from crontab so there will be an email sent to users every
  time.
  
  - install the patched version, and run the above command again, it should
  be quiet, without any messages.
  
  REGRESSION POTENTIAL: low. According to the mailmanctl help page:
  
      -q/--quiet
        Don't print status messages.  Error messages are still printed to
        standard error.
  
- By applying this patch, users will not get the informational messages but
- they will still get any error message.
+ By applying this patch, users will not get the informational messages
+ but they will still get any error message.

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/244233

Title:
  Logrotate is noisy with: Re-opening all log files