[Bug 610364] Re: fix_url won't save list as no Lock

Mark Sapiro mark at msapiro.net
Tue Jul 27 15:54:54 CEST 2010


Your suggested fix has two serious problems:

1) Locking the list reloads it as a side effect. Thus, locking after
making changes to your instance of the list object will undo those
changes.

2) The documentation of fix_url states that it should be run via

% bin/withlist -l -r fix_url listname [options]

Thus, if it is run as documented (with the -l option to withlist), it
will throw an AlreadyLockedError exception when it attempts to lock the
already locked list.

While this isn't really a bug since fix_url is documented to be run via
withlist -l, a patch to "fix" it properly is attached

** Attachment added: "Patch to fix_url to lock an unlocked list."
   http://launchpadlibrarian.net/52587192/patch

-- 
fix_url won't save list as no Lock
https://bugs.launchpad.net/bugs/610364
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.


More information about the Mailman-coders mailing list