From 727602 at bugs.launchpad.net  Wed Mar  2 06:47:23 2011
From: 727602 at bugs.launchpad.net (Worik)
Date: Wed, 02 Mar 2011 05:47:23 -0000
Subject: [Bug 727602] [NEW] who command did not work with "who" in subject line
References: <20110302054723.31147.22067.malonedeb@gandwana.canonical.com>
Message-ID: <20110302054723.31147.22067.malonedeb@gandwana.canonical.com>

Public bug reported:

I got the who command to work emailing -request by having a blank
subject line.  If I used a subject line that was blank it worked.

The command info worked with info in the subject line.

cheers
W

** Affects: mailman
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/727602

Title:
  who command did not work with "who" in subject line

From mark at msapiro.net  Wed Mar  2 08:01:45 2011
From: mark at msapiro.net (Mark Sapiro)
Date: Wed, 02 Mar 2011 07:01:45 -0000
Subject: [Bug 727602] Re: who command did not work with "who" in subject line
References: <20110302054723.31147.22067.malonedeb@gandwana.canonical.com>
Message-ID: <20110302070145.11132.40405.malone@soybean.canonical.com>

What exactly did you have in the subject and body?

For example, if the roster is limited to list members or the admin, the
required command form is

  who <password>

If you put just "who" in the subject and "who <password>" in the body,
Mailman will first process the "who" command in the subject. Since it
doesn't have an appropriate password, it fails and no more commands,
including the valid command in the body, are processed.

The subject of an email to the -request address can be a command. If it
doesn't begin with a valid command word, it is ignored, but if it does
begin with a valid command word, but the full subject is not a valid
command, it is an error and no further commands will be processed.

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/727602

Title:
  who command did not work with "who" in subject line

From 727602 at bugs.launchpad.net  Wed Mar  2 08:44:18 2011
From: 727602 at bugs.launchpad.net (Worik)
Date: Wed, 02 Mar 2011 07:44:18 -0000
Subject: [Bug 727602] Re: who command did not work with "who" in subject
	line
References: <20110302054723.31147.22067.malonedeb@gandwana.canonical.com>
	<20110302070145.11132.40405.malone@soybean.canonical.com>
Message-ID: <4D6DF552.2000803@gmail.com>

On 02/03/11 20:01, Mark Sapiro wrote:
> What exactly did you have in the subject and body?
>
The subject was "who" on its own


The body was some variation of..

who XXXXXXX address=worik.stanton at gmail.com
end

-- 
If we amplify everything, we hear nothing.
-- 


> The subject of an email to the -request address can be a command. If it
> doesn't begin with a valid command word, it is ignored, but if it does
> begin with a valid command word, but the full subject is not a valid
> command, it is an error and no further commands will be processed.
I think "who" on its own should be OK.  But perhaps I should have put in 
"who XXXXXX address=worik.stanton at gmail.com " as a subject.

If so this is an error message bug.

cheers
Worik

-- 
If we amplify everything, we hear nothing.
--

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/727602

Title:
  who command did not work with "who" in subject line

From mark at msapiro.net  Wed Mar  2 09:10:40 2011
From: mark at msapiro.net (Mark Sapiro)
Date: Wed, 02 Mar 2011 08:10:40 -0000
Subject: [Bug 727602] Re: who command did not work with "who" in subject line
References: <20110302054723.31147.22067.malonedeb@gandwana.canonical.com>
Message-ID: <20110302081040.4053.74528.malone@wampee.canonical.com>

Perhaps it is an error message bug. What response did you get?

Why do you think "who" on its own should be OK? This is only acceptable
if the roster is public. If the roster is not public, password
authentication as a member (if the roster is available to list members)
or as a list admin or moderator is required.

If the command should be "who XXXXXX address=worik.stanton at gmail.com"
then putting that in the subject will work, and putting that in the body
with no subject or at least a non-command subject will work, but putting
that in the body with just "who" in the subject should give a usage
message in response to the "who" in the subject and indicate that the
"who XXXXXX address=worik.stanton at gmail.com" in the body was
unprocessed.

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/727602

Title:
  who command did not work with "who" in subject line

From 736849 at bugs.launchpad.net  Thu Mar 17 14:18:42 2011
From: 736849 at bugs.launchpad.net (Joseph Brennan)
Date: Thu, 17 Mar 2011 13:18:42 -0000
Subject: [Bug 736849] [NEW] Sender header change to improve Outlook
References: <20110317131842.13623.89204.malonedeb@potassium.ubuntu.com>
Message-ID: <20110317131842.13623.89204.malonedeb@potassium.ubuntu.com>

Public bug reported:

FAQ 2.3 describes problems with Outlook's ugly display of Sender "on
behalf of" From, giving the example as "From listname-
bounces at mailman.server.com On behalf of fred at poster.domain.com".  But
Outlook prefers to show the real name and hide the Internet address,
when a real name is present.  Most commonly the From would be "From:
Fred Example <fred at poster.domain.com>" and as a result Outlook would
display "From listname-bounces at mailman.server.com On behalf of Fred
Example".

If Mailman wrote the Sender header with a real name Outlook would show
the name there too. For example, if the list name (local part) were
inserted, thus "Sender: listname <listname-bounces at mailman.server.com>",
then Outlook would display "From listname on behalf of Fred Example"
which is much better in appearance and still complies with using a
Sender header.

RFC 2822 allows Sender to contain a real name.
sender          =       "Sender:" mailbox CRLF
mailbox         =       name-addr / addr-spec
name-addr       =       [display-name] angle-addr

** Affects: mailman
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/736849

Title:
  Sender header change to improve Outlook

From mark at msapiro.net  Thu Mar 17 22:51:48 2011
From: mark at msapiro.net (Mark Sapiro)
Date: Thu, 17 Mar 2011 21:51:48 -0000
Subject: [Bug 736849] Re: Sender header change to improve Outlook
References: <20110317131842.13623.89204.malonedeb@potassium.ubuntu.com>
Message-ID: <20110317215149.27689.7806.malone@soybean.canonical.com>

This seems like a great idea. Why didn't someone think of this years
ago?

** Changed in: mailman
   Importance: Undecided => Medium

** Changed in: mailman
       Status: New => Triaged

** Changed in: mailman
    Milestone: None => 2.1.15

** Changed in: mailman
     Assignee: (unassigned) => Mark Sapiro (msapiro)

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/736849

Title:
  Sender header change to improve Outlook

From 739524 at bugs.launchpad.net  Mon Mar 21 18:10:05 2011
From: 739524 at bugs.launchpad.net (Joseph Brennan)
Date: Mon, 21 Mar 2011 17:10:05 -0000
Subject: [Bug 739524] [NEW] Administrivia 'who' matches too much
References: <20110321171005.15489.49435.malonedeb@soybean.canonical.com>
Message-ID: <20110321171005.15489.49435.malonedeb@soybean.canonical.com>

Public bug reported:

Mailman/Utils.py has:    'who':         (0, 2),
This matches subject and start-of-line with many ordinary-language sentences or headings like 'who are you?' or 'Who is affected:'. I suggest dialing it back to (0, 1) which would have far fewer false positives, or even (0, 0) as it once was.

** Affects: mailman
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/739524

Title:
  Administrivia 'who' matches too much

From mark at msapiro.net  Mon Mar 21 20:11:07 2011
From: mark at msapiro.net (Mark Sapiro)
Date: Mon, 21 Mar 2011 19:11:07 -0000
Subject: [Bug 739524] Re: Administrivia 'who' matches too much
References: <20110321171005.15489.49435.malonedeb@soybean.canonical.com>
Message-ID: <20110321191107.24511.41223.malone@wampee.canonical.com>

I think the consequences of allowing mail with the command "who
<password>" containing the list admin password to go to the list if
inadvertently sent to the list posting address are more serious than the
consequences of a false positive administrivia hold.

The "who <password> address=<address>" form is probably less used and
less likely to contain the list password, since the address= option is
irrelevant if the password is the list admin or moderator password.
Since the argument count range was (0, 0) prior to Mailman 2.1.10, I
think changing it to (0, 1) is OK, but I think (0, 0) has too much risk.

Also, note that any message that contains more than
DEFAULT_MAIL_COMMANDS_MAX_LINES non-blank body lines prior to any '-- '
signature separator is not administrivia, so reducing
DEFAULT_MAIL_COMMANDS_MAX_LINES from the default 25 can also reduce the
false positives.

** Changed in: mailman
   Importance: Undecided => Low

** Changed in: mailman
       Status: New => Triaged

** Changed in: mailman
    Milestone: None => 2.1.15

** Changed in: mailman
     Assignee: (unassigned) => Mark Sapiro (msapiro)

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/739524

Title:
  Administrivia 'who' matches too much

From 739524 at bugs.launchpad.net  Mon Mar 21 20:52:49 2011
From: 739524 at bugs.launchpad.net (Joseph Brennan)
Date: Mon, 21 Mar 2011 19:52:49 -0000
Subject: [Bug 739524] Re: Administrivia 'who' matches too much
References: <20110321171005.15489.49435.malonedeb@soybean.canonical.com>
Message-ID: <20110321195249.15565.62868.malone@soybean.canonical.com>

As a new-ish Mailman admin I couldn't say how common the 1 and 2 args
would be -- need you to judge.  And I missed
DEFAULT_MAIL_COMMANDS_MAX_LINES-- thank you.

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/739524

Title:
  Administrivia 'who' matches too much

From mark at msapiro.net  Mon Mar 21 22:15:32 2011
From: mark at msapiro.net (Mark Sapiro)
Date: Mon, 21 Mar 2011 21:15:32 -0000
Subject: [Bug 739524] Re: Administrivia 'who' matches too much
References: <20110321171005.15489.49435.malonedeb@soybean.canonical.com>
Message-ID: <20110321211533.15489.16377.malone@soybean.canonical.com>

Committed change from (0, 2) to (0, 1).

** Changed in: mailman
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/739524

Title:
  Administrivia 'who' matches too much

From mark at msapiro.net  Mon Mar 21 22:16:39 2011
From: mark at msapiro.net (Mark Sapiro)
Date: Mon, 21 Mar 2011 21:16:39 -0000
Subject: [Bug 736849] Re: Sender header change to improve Outlook
References: <20110317131842.13623.89204.malonedeb@potassium.ubuntu.com>
Message-ID: <20110321211640.6291.34251.launchpad@gandwana.canonical.com>

** Changed in: mailman
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/736849

Title:
  Sender header change to improve Outlook

From mark at msapiro.net  Wed Mar 30 05:35:18 2011
From: mark at msapiro.net (Mark Sapiro)
Date: Wed, 30 Mar 2011 03:35:18 -0000
Subject: [Bug 745432] Re: Email address with leading or trailing space is not
	accepted by web subscribe.
References: <20110330031839.17714.44578.malonedeb@wampee.canonical.com>
Message-ID: <20110330033518.16948.50311.launchpad@wampee.canonical.com>

** Changed in: mailman
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/745432

Title:
  Email address with leading or trailing space is not accepted by web
  subscribe.

From mark at msapiro.net  Wed Mar 30 05:18:39 2011
From: mark at msapiro.net (Mark Sapiro)
Date: Wed, 30 Mar 2011 03:18:39 -0000
Subject: [Bug 745432] [NEW] Email address with leading or trailing space is
	not accepted by web subscribe.
References: <20110330031839.17714.44578.malonedeb@wampee.canonical.com>
Message-ID: <20110330031839.17714.44578.malonedeb@wampee.canonical.com>

Public bug reported:

If an address is entered on the web listinfo subscribe form with a
leading or trailing space, it is rejected with the message "The email
address you supplied is not valid. (E.g. it must contain an '@'.)". This
is confusing to the user who looks at the address and sees it does
contain an '@' and appears valid.

Leading and trailing whitespace should be stripped from the address
entry.

** Affects: mailman
     Importance: Low
     Assignee: Mark Sapiro (msapiro)
         Status: In Progress

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/745432

Title:
  Email address with leading or trailing space is not accepted by web
  subscribe.

From mss at msquadrat.de  Thu Mar 31 16:30:20 2011
From: mss at msquadrat.de (Malte S. Stretz)
Date: Thu, 31 Mar 2011 14:30:20 -0000
Subject: [Merge] lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman
Message-ID: <20110331143011.27117.73509.launchpad@loganberry.canonical.com>

Malte S. Stretz has proposed merging lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman.

Requested reviews:
  Mailman Coders (mailman-coders)

For more details, see:
https://code.launchpad.net/~mss/mailman/3.0-smtp-log-fix/+merge/55760

Trivial change: mailman.mta.base did log non-existent Message-Ids as None instead of n/a like .delivers does.
-- 
https://code.launchpad.net/~mss/mailman/3.0-smtp-log-fix/+merge/55760
Your team Mailman Coders is requested to review the proposed merge of lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 483 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/mailman-coders/attachments/20110331/49d25870/attachment.diff>

From barry at canonical.com  Thu Mar 31 17:41:56 2011
From: barry at canonical.com (Barry Warsaw)
Date: Thu, 31 Mar 2011 15:41:56 -0000
Subject: [Merge] lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman
In-Reply-To: <20110331143011.27117.73509.launchpad@loganberry.canonical.com>
Message-ID: <20110331154155.29543.89700.codereview@wampee.canonical.com>

Thanks for the patch.  I'm going to try to write a test for this, but can you tell me in what situation you're seeing the None's?  Having a Message-ID header should be a requirement once the message is in the system, so if there are entry points which don't ensure that header, it might be better (or at least *also*) to fix that.
-- 
https://code.launchpad.net/~mss/mailman/3.0-smtp-log-fix/+merge/55760
Your team Mailman Coders is requested to review the proposed merge of lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman.

From mss at msquadrat.de  Thu Mar 31 18:06:08 2011
From: mss at msquadrat.de (Malte S. Stretz)
Date: Thu, 31 Mar 2011 16:06:08 -0000
Subject: [Merge] lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman
In-Reply-To: <20110331143011.27117.73509.launchpad@loganberry.canonical.com>
Message-ID: <20110331160434.32731.54299.codereview@soybean.canonical.com>

I just tested mailman by speaking via netcat to the LMTP port.  And I was too lazy to type a Message-Id header.

I think it should be fine to refuse the mail if there Message-Id header is missing (the mda should have added one already).
-- 
https://code.launchpad.net/~mss/mailman/3.0-smtp-log-fix/+merge/55760
Your team Mailman Coders is requested to review the proposed merge of lp:~mss/mailman/3.0-smtp-log-fix into lp:mailman.