[Bug 788309] Re: Site template search should look in var_dir

Barry Warsaw 788309 at bugs.launchpad.net
Wed May 25 22:27:23 CEST 2011


I changed the subject of this bug because actually I think it's fine for
the in-tree site templates to still be searched, just that if the
template exists in $var_dir, it should override.  And this should be
true of the domain templates as well.

Thanks for the patch, and the bug report.  Perhaps you'd like to refine
the patch to match the new description?  Also, if you could include
unittests that would be great.

** Summary changed:

- Site configuration customization unnecessarily stored in tree
+ Site template search should look in var_dir

** Summary changed:

- Site template search should look in var_dir
+ Allow $var_dir templates to override in-tree templates

** Description changed:

- The i18n templates for site customization are specified to be in
- <template_dir>/site/ etc., a part of the tree, rather than being placed
- in <var_dir> (outside the tree)
- 
- Solution, move them to <var_dir>/templates/site/
+ mailman.utilities.i18n.find()'s search algorithm only allows for list-
+ specific templates in $var_dir.  The search algorithm should be extended
+ so that any of the domain, site, and language templates may be
+ overridden by $var_dir templates.  It can still fallback to in-tree
+ templates if the $var_dir version is missing.

** Changed in: mailman
       Status: New => Confirmed

** Changed in: mailman
   Importance: Undecided => Medium

** Changed in: mailman
   Importance: Medium => Wishlist

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/788309

Title:
  Allow $var_dir templates to override in-tree templates


More information about the Mailman-coders mailing list