[Bug 890675] Re: test_moderation fails on approved_at date comparison

Barry Warsaw 890675 at bugs.launchpad.net
Fri Feb 17 20:09:43 CET 2012

Aamir, the '-' at the end of the date is left over from trying to strip
out the timezone information, which will be different everywhere you run
the test suite.  Because that's unpredictable data, it must be removed
from the test output, or you'll get the failure as you've seen.
blacktav's diff in comment #1 is the more correct fix for this problem,
because it correctly strips off the +- sign, which indicates whether
your timezone is east or west of UTC.  Because I'm west of UTC, it's
negative for me.  I'm guessing your east of UTC, so that's why it is
positive for you.

This is definitely an easy fix, but here is my suggestion: why don't you
create a branch of lp:mailman, apply blacktav's patch and run the test
suite to ensure that it fixes the failure.  If so, learn how to use bzr
to commit the change locally, and then push your branch to Launchpad,
using something like lp:~sys3mw0rm/mailman/bug-890675.  Then you can use
`bzr lp-propose` to submit a merge proposal into trunk.  Please include
a NEWS.rst file entry (see examples in that file) and please do give due
credit to blacktav as well.

Once you've submitted the merge proposal, I'll review it and commit it
to trunk.  This will give you a great opportunity to learn a bit about
the code, and how we accept contributions.  Ping me on IRC if you have

** Changed in: mailman
       Status: New => Confirmed

** Changed in: mailman
   Importance: Undecided => Medium

** Changed in: mailman
    Milestone: None => 3.0.0b1

You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.

  test_moderation fails on approved_at date comparison

To manage notifications about this bug go to:

More information about the Mailman-coders mailing list