[Merge] lp:~pskoli93/postorius/validation-fix into lp:postorius

Pavan Koli pskoli93 at gmail.com
Wed Apr 8 08:26:23 CEST 2015


Pavan Koli has proposed merging lp:~pskoli93/postorius/validation-fix into lp:postorius.

Commit message:
Fixes to validation during mass subscription

Requested reviews:
  Florian Fuchs (flo-fuchs)
Related bugs:
  Bug #1441314 in Postorius: "Wrong email ids passing validation during mass subscription"
  https://bugs.launchpad.net/postorius/+bug/1441314

For more details, see:
https://code.launchpad.net/~pskoli93/postorius/validation-fix/+merge/255461

While using the mass subscription option to subscribe many email ids, email ids such as '@gmail.com' are passing through.

Django validators have been used now to validate the email ids.

Also some changes have been made to the file postorius/src/postorius/forms.py. On leaving the Mail Host and Web Host column blank while creating a new domain, a message 'Please a domain name' used to get displayed which seems not to help much. Change has been made to now display 'Please enter a Mail Host' and 'Please enter a Web Host' if you leave that respective column blank.
-- 
Your team Mailman Coders is subscribed to branch lp:postorius.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4021 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/mailman-coders/attachments/20150408/eabbe5df/attachment.diff>


More information about the Mailman-coders mailing list