[Merge] lp:~pskoli93/postorius/Models into lp:postorius

Pavan Koli pskoli93 at gmail.com
Tue Apr 14 07:05:31 CEST 2015


Pavan Koli has proposed merging lp:~pskoli93/postorius/Models into lp:postorius.

Commit message:
Fix for Attribute error raised during addition of new email id.

Requested reviews:
  Terri (terriko)
Related bugs:
  Bug #1430682 in Postorius: "AttributeError at /postorius/users/address_activation/"
  https://bugs.launchpad.net/postorius/+bug/1430682
  Bug #1437866 in Postorius: "AttributeError while adding another email address to your account"
  https://bugs.launchpad.net/postorius/+bug/1437866

For more details, see:
https://code.launchpad.net/~pskoli93/postorius/Models/+merge/256102

Failing to configure EMAIL_CONFIRMATION_FROM raised an attribute error instead of ImproperlyConfigured Error. 

Now this fix lets it check if EMAIL_CONFIRMATION_FROM is configured or not, if not then it checks for configuration of DEFAULT_FROM_EMAIL. Even if it is not configured than ImproperlyConfigured Error is raised. This error helps to identify that there are faults in the configuration and not in the code.
-- 
Your team Mailman Coders is subscribed to branch lp:postorius.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1235 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/mailman-coders/attachments/20150414/67bbfda9/attachment.diff>


More information about the Mailman-coders mailing list