[Merge] lp:~pskoli93/postorius/Helptext-Fixes into lp:postorius
Pavan Koli
pskoli93 at gmail.com
Sat Apr 25 15:27:22 CEST 2015
Pavan Koli has proposed merging lp:~pskoli93/postorius/Helptext-Fixes into lp:postorius.
Requested reviews:
Mailman Coders (mailman-coders)
For more details, see:
https://code.launchpad.net/~pskoli93/postorius/Helptext-Fixes/+merge/257460
If we go to a list settings page and click on the question mark to open the more info tab, a new tab opens with an error that ListSettings is not defined globally.
Initially a ListSettings form was there but now different forms have been created for different list tasks like ListIdentityForm, ListAutomaticResponseForm etc. In all these forms if a user clicks on more info tab the 'formid' is equal to 'list_settings' and every form has the same 'formid', so there is no clear way to identify for which forms' option the more info is sought.
The solution to this is that a separate list(Python list) has been created for the separate forms with the 'helpid' stored in these lists(Python list). Now if a user clicks on more info tab we check which list(Python list) it corresponds to, by comparing the 'helpid', and then loading the appropriate help text from the appropriate form.
--
Your team Mailman Coders is requested to review the proposed merge of lp:~pskoli93/postorius/Helptext-Fixes into lp:postorius.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2300 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/mailman-coders/attachments/20150425/38de2543/attachment.diff>
More information about the Mailman-coders
mailing list