[Merge] lp:~bhavesh-goyal093/postorius/feature-added-mass-removal into lp:postorius
Florian Fuchs
f at florianfuchs.com
Wed Mar 11 16:37:16 CET 2015
Review: Needs Fixing
Hi Bhavesh,
thanks for your merge proposal! These are useful additions.
My major concern is the JS-based confirmation: If someone doesn't have JS activated, the removal will happen immediately. Given that the members are a list's most valued assets that's just a little too risky IMO. How about using a separate confirmation page for that? The text area values could be stored in another form on that page, along with a hidden "confirm" field, so the corresponding view function knows that the user really intends to remove the given members (or all of them).
Thanks!
Florian
--
https://code.launchpad.net/~bhavesh-goyal093/postorius/feature-added-mass-removal/+merge/252595
Your team Mailman Coders is subscribed to branch lp:postorius.
More information about the Mailman-coders
mailing list