[Bug 1418276] Re: Deleting a user via the REST API does not delete their user preferences

Barry Warsaw 1418276 at bugs.launchpad.net
Fri Mar 20 17:43:48 CET 2015


Thanks for the patch and the test, it's a great contribution.  I am
going to apply it with some modifications.  Here is some feedback for
the future:

Please read PEP 8 and the Mailman style guide for our coding standards.

Because the fix is in the model, there should be a test in the model.
It's okay to also have a test in the REST layer because that's where the
problem was observed.  I adapted your REST test and added one to the
model.

Be sure to run the full test suite with `tox` both before and after
applying your fix.  It's a good idea to add the test, run tox to
validate that the test fails, then add your fix to validate that it
succeeds.  Also, running the full suite before submitting a patch
ensures that there are no regressions elsewhere in Mailman.

When attributing fixes by community members, I use the name given in
your Launchpad id.  If you want your full name to appear in the NEWS
file, please contact me directly.

See r7307 for the full, applied patch.

** Changed in: mailman
    Milestone: None => 3.0.0b6

** Changed in: mailman
   Importance: Undecided => High

** Changed in: mailman
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mailman
Coders, which is subscribed to GNU Mailman.
https://bugs.launchpad.net/bugs/1418276

Title:
  Deleting a user via the REST API does not delete their user
  preferences

To manage notifications about this bug go to:
https://bugs.launchpad.net/mailman/+bug/1418276/+subscriptions


More information about the Mailman-coders mailing list