[Merge] lp:~bhavesh-goyal093/postorius/fixed-nav-role-identification into lp:postorius

Bhavesh Goyal bhavesh.goyal093 at gmail.com
Sun Mar 22 16:08:25 CET 2015


Bhavesh Goyal has proposed merging lp:~bhavesh-goyal093/postorius/fixed-nav-role-identification into lp:postorius.

Requested reviews:
  Mailman Coders (mailman-coders)
Related bugs:
  Bug #1431474 in Postorius: "User roles not correctly identified in postorius nav bar"
  https://bugs.launchpad.net/postorius/+bug/1431474

For more details, see:
https://code.launchpad.net/~bhavesh-goyal093/postorius/fixed-nav-role-identification/+merge/253771

Fixed Bug #1431474

Mailman offers different views for different roles in list nav bar. Earlier if the user had some access privileges for instance (a moderator), the the nav bar options which he got were the same as that of a normal subscriber. Manually opening the page from URL though allowed the user to access the privileged controls.
Now, a correct view is given for each of the member roles by changing the if condition of list_summary template which was earlier set to display nav options only for super users.

Also, Certain List Pages such as Held_messages were not accessible to moderators even though they have the right to access them and were given only to owners. Now The Permissions of the page are also corrected and set to moderators which hold actual control for those pages.
-- 
Your team Mailman Coders is requested to review the proposed merge of lp:~bhavesh-goyal093/postorius/fixed-nav-role-identification into lp:postorius.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2152 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/mailman-coders/attachments/20150322/50a5cf70/attachment.diff>


More information about the Mailman-coders mailing list