From 1446881 at bugs.launchpad.net Sat Jan 6 04:59:07 2018 From: 1446881 at bugs.launchpad.net (ivan) Date: Sat, 06 Jan 2018 09:59:07 -0000 Subject: [Bug 1446881] Re: Require Falcon 0.3 References: <20150421221658.16455.85553.malonedeb@soybean.canonical.com> Message-ID: <151523274722.411.11991807519008546132.malone@wampee.canonical.com> Ivan117 admin -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1446881 Title: Require Falcon 0.3 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1446881/+subscriptions From thh at inter.net Sat Jan 6 18:16:28 2018 From: thh at inter.net (Thomas Hochstein) Date: Sat, 06 Jan 2018 23:16:28 -0000 Subject: [Merge] lp:~thochstein/mailman/german-translation into lp:mailman/2.1 Message-ID: <151528058620.23363.17496202485515828044.launchpad@ackee.canonical.com> Thomas Hochstein has proposed merging lp:~thochstein/mailman/german-translation into lp:mailman/2.1. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~thochstein/mailman/german-translation/+merge/335798 Update German translation. * Fixing 2 typos. * Add missing commas, one missing hyphen and one missing full stop. * Change wording (due to a hardcoded plural form). -- Your team Mailman Coders is requested to review the proposed merge of lp:~thochstein/mailman/german-translation into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 5033 bytes Desc: not available URL: From fmouse at fmp.com Sat Jan 6 18:59:22 2018 From: fmouse at fmp.com (Lindsay) Date: Sat, 06 Jan 2018 23:59:22 -0000 Subject: [Merge] lp:~fmouse/mailman/mailman-config into lp:mailman/2.1 Message-ID: <151528315996.2983.5106269551255422292.launchpad@ackee.canonical.com> Lindsay has proposed merging lp:~fmouse/mailman/mailman-config into lp:mailman/2.1. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~fmouse/mailman/mailman-config/+merge/335799 mailman-config.py is added to the build/contrib directory when configure is run, and when executed, emits, to stdout, a number of useful configuration options, including the option string provided to configure at build time. This is useful when updating Mailman 2, or when trying to synchronize a manual install of Mailman with a distribution's FHS. -- Your team Mailman Coders is requested to review the proposed merge of lp:~fmouse/mailman/mailman-config into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 3858 bytes Desc: not available URL: From pmlists at free.fr Sun Jan 14 15:25:19 2018 From: pmlists at free.fr (Peter) Date: Sun, 14 Jan 2018 20:25:19 -0000 Subject: [Bug 1743250] [NEW] support for RFC 6531 Message-ID: <151596151976.20056.4234330009353924088.malonedeb@chaenomeles.canonical.com> Public bug reported: Hi, Could you please add support for UTF8 in email addresses? For example: caf?@example.com Please tell me, if you need some funding for implementing this feature. TIA for your help. Kind regards, Peter ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1743250 Title: support for RFC 6531 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1743250/+subscriptions From mark at msapiro.net Sun Jan 14 20:29:46 2018 From: mark at msapiro.net (Mark Sapiro) Date: Mon, 15 Jan 2018 01:29:46 -0000 Subject: [Bug 1743250] Re: support for RFC 6531 References: <151596151976.20056.4234330009353924088.malonedeb@chaenomeles.canonical.com> Message-ID: <151597978699.10657.16967862194577708188.malone@gac.canonical.com> What are you looking for in the way of support? Presumably you want to be able to subscribe UTF-8 encoded addresses with non-ascii. Do you also want to allow non-ascii list names? I would be inclined to only support this as a site option. Should it also be contingent on the outgoing MTA offering SMTPUTF8? I'm sure we will have to support this at some point in Mailman 3, but it may not ever be in Mailman 2.1. ** Changed in: mailman Importance: Undecided => Wishlist ** Changed in: mailman Status: New => Incomplete -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1743250 Title: support for RFC 6531 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1743250/+subscriptions From pmlists at free.fr Mon Jan 15 01:12:47 2018 From: pmlists at free.fr (Peter) Date: Mon, 15 Jan 2018 06:12:47 -0000 Subject: [Bug 1743250] Re: support for RFC 6531 References: <151596151976.20056.4234330009353924088.malonedeb@chaenomeles.canonical.com> Message-ID: <151599676764.19986.5562927743753097032.malone@chaenomeles.canonical.com> On Mon, Jan 15 2018, Mark Sapiro wrote: > Presumably you want to be able to subscribe UTF-8 encoded addresses > with non-ascii. Yes, but it's less important. > Do you also want to allow non-ascii list names? Yes, this is the feature, I'm looking for. > I would be inclined to only support this as a site option. Ok. > Should it also be contingent on the outgoing MTA offering SMTPUTF8? Yes, this makes sense. (Postfix supports it without problems.) I would like to see this feature as soon as possible in Mailman 3. Funding is possible. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1743250 Title: support for RFC 6531 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1743250/+subscriptions From mark at msapiro.net Mon Jan 15 15:49:11 2018 From: mark at msapiro.net (Mark Sapiro) Date: Mon, 15 Jan 2018 20:49:11 -0000 Subject: [Bug 1743250] Re: support for RFC 6531 References: <151596151976.20056.4234330009353924088.malonedeb@chaenomeles.canonical.com> Message-ID: <151604935189.10413.18332062035755925791.malone@gac.canonical.com> It would be good to submit this issue at https://gitlab.com/mailman/mailman/issues/ for Mailman 3. ** Changed in: mailman Status: Incomplete => Triaged -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1743250 Title: support for RFC 6531 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1743250/+subscriptions From pmlists at free.fr Tue Jan 16 01:17:36 2018 From: pmlists at free.fr (Peter) Date: Tue, 16 Jan 2018 06:17:36 -0000 Subject: [Bug 1743250] Re: support for RFC 6531 References: <151596151976.20056.4234330009353924088.malonedeb@chaenomeles.canonical.com> Message-ID: <151608345658.4927.5427058822933963070.malone@wampee.canonical.com> Ok, done. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1743250 Title: support for RFC 6531 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1743250/+subscriptions From futatuki at poem.co.jp Sun Jan 21 14:05:31 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Sun, 21 Jan 2018 19:05:31 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 Message-ID: <151656152952.19290.1893838088086436698.launchpad@ackee.canonical.com> Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/336404 Update Japanese translation for * message change in Mailman/Handlers/SpamDetect.py (lp:mailman/2.1 Rev. 1730) * docstring for bin/mail-manconfig added (lp:mailman/2.1 Rev. 1734) -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 799 bytes Desc: not available URL: From 1744739 at bugs.launchpad.net Mon Jan 22 10:32:25 2018 From: 1744739 at bugs.launchpad.net (David Runge) Date: Mon, 22 Jan 2018 15:32:25 -0000 Subject: [Bug 1744739] [NEW] 2.1.25 login based pages not working with uwsgi Message-ID: <151663514548.4431.13685248957496009295.malonedeb@wampee.canonical.com> Public bug reported: Mailman 2.1.25's login based pages (private archives, admin page, etc.) don't work with uwsgi (uwsgi times out printing a "invalid CGI response !!!" error). Downgrading to 2.1.24 fixes this issue (I can again log in and uwsgi doesn't reply with the "invalid CGI response !!!" message). I'm on Arch Linux trying to use mailman 2.1.25 with uwsgi 2.0.15 through nginx 1.12.2. I've also opened a downstream bug there [1]. For completeness I will attach the same log files as in the aforementioned bug report. The uwsgi configuration in use for mailman is pretty straight forward: `` [uwsgi] procname-master = mailman master = true plugins = cgi socket = /run/uwsgi/%n.sock stats = /run/uwsgi/%n-stats.sock processes = 1 threads = 2 cheaper-step = 1 idle = 120 die-on-idle = true uid = http gid = http cgi = /=/usr/lib/mailman/cgi-bin cgi-index = listinfo `` Nginx fronts the application server and redirects to a unix socket, which in turn starts a systemd service. More info on the setup can be found on my website [2]. `` [Unit] Description=uWSGI service unit After=syslog.target [Service] ExecStart=/usr/bin/uwsgi --ini /etc/uwsgi/%I.ini Type=notify SuccessExitStatus=15 17 29 30 StandardError=syslog NotifyAccess=all KillSignal=SIGQUIT PrivateDevices=yes PrivateTmp=yes ProtectSystem=full ReadWriteDirectories=/etc/webapps ProtectHome=yes [Install] WantedBy=multi-user.target `` `` [Unit] Description=Socket for uWSGI %I [Socket] ListenStream=/run/uwsgi/%I.sock [Install] WantedBy=sockets.target `` [1] https://bugs.archlinux.org/task/56865 [2] https://sleepmap.de/2016/securely-serving-webapps-using-uwsgi/ ** Affects: mailman Importance: Undecided Status: New ** Tags: nginx uwsgi ** Attachment added: "uwsgi log for mailman" https://bugs.launchpad.net/bugs/1744739/+attachment/5041051/+files/uwsgi-mailman.txt -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1744739 Title: 2.1.25 login based pages not working with uwsgi To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions From mark at msapiro.net Mon Jan 22 23:20:15 2018 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 23 Jan 2018 04:20:15 -0000 Subject: [Bug 1744739] Re: 2.1.25 login based pages not working with uwsgi References: <151663514548.4431.13685248957496009295.malonedeb@wampee.canonical.com> Message-ID: <151668121559.19687.13249170906518283809.malone@chaenomeles.canonical.com> I am not familiar with uwsgi, so I really don't understand what's going on, but what I can tell you is between Mailman 2.1.24 and Mailman 2.1 25 There were no changes in Mailman/SecurityManager.py or Mailman/Cgi/Auth.py which are the modules that have to do with logging in and passwords. The only change in Mailman/Cgi/private.py changed a getting the username and password from username = cgidata.getvalue('username', '') password = cgidata.getvalue('password', '') to username = cgidata.getfirst('username', '') password = cgidata.getfirst('password', '') There were similar changes amongst others in Mailman/Cgi/admin.py and Mailman/Cgi/admindb.py In the above, cgidata is an instance of the Python standard library cgi.FieldStorage class. See https://docs.python.org/2/library/cgi.html #higher-level-interface - the difference is getvalue() can return a string or a list depending of whether the post data contains a single or multiple settings for the variable. getfirst always returns a single value, never a list. However, this all occurs in handling the CGI input passed to the invoked process so it's hard to see how this would produce what you are seeing. As far as output from the CGI is concerned, there should be no change at all to that from 'private'. 'admin' and 'admindb' do have some changes in CSS to support enhanced accessibility for visually impaired users, but nothing else. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1744739 Title: 2.1.25 login based pages not working with uwsgi To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions From 1744739 at bugs.launchpad.net Thu Jan 25 06:57:47 2018 From: 1744739 at bugs.launchpad.net (David Runge) Date: Thu, 25 Jan 2018 11:57:47 -0000 Subject: [Bug 1744739] Re: 2.1.25 login based pages not working with uwsgi References: <151663514548.4431.13685248957496009295.malonedeb@wampee.canonical.com> Message-ID: <151688146780.25325.4423673606851815460.malone@wampee.canonical.com> Hmm, I wonder where to start debugging. Might need to find an easy way of reverting the above mentioned changes and try again... -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1744739 Title: 2.1.25 login based pages not working with uwsgi To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions From mark at msapiro.net Fri Jan 26 17:42:07 2018 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 26 Jan 2018 22:42:07 -0000 Subject: [Bug 1744739] Re: 2.1.25 login based pages not working with uwsgi References: <151663514548.4431.13685248957496009295.malonedeb@wampee.canonical.com> Message-ID: <151700652744.17515.3227072339855353030.malone@chaenomeles.canonical.com> I have rethought this, and I think my focus on changes to the CGI modules was a red herring. I think it's much more likely that http://bazaar.launchpad.net/~mailman-coders/mailman/2.1/revision/1720 is responsible. I suspect your nginx/uwsgi setup depends on passing some environment variable through the CGI wrapper that we are now (as of 2.1.25) not passing. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1744739 Title: 2.1.25 login based pages not working with uwsgi To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions From 1744739 at bugs.launchpad.net Fri Jan 26 18:42:29 2018 From: 1744739 at bugs.launchpad.net (David Runge) Date: Fri, 26 Jan 2018 23:42:29 -0000 Subject: [Bug 1744739] Re: 2.1.25 login based pages not working with uwsgi References: <151663514548.4431.13685248957496009295.malonedeb@wampee.canonical.com> Message-ID: <151701014947.7610.14372541768061401431.malone@soybean.canonical.com> That sounds plausible. I can show you what nginx does in my case (the relevant part): `` # Send all access to / to uwsgi location / { gzip off; include uwsgi_params; uwsgi_modifier1 9; uwsgi_pass unix:/run/uwsgi/mailman.sock; } `` where uwsgi_params consists of the standard, shipped params: `` uwsgi_param QUERY_STRING $query_string; uwsgi_param REQUEST_METHOD $request_method; uwsgi_param CONTENT_TYPE $content_type; uwsgi_param CONTENT_LENGTH $content_length; uwsgi_param REQUEST_URI $request_uri; uwsgi_param PATH_INFO $document_uri; uwsgi_param DOCUMENT_ROOT $document_root; uwsgi_param SERVER_PROTOCOL $server_protocol; uwsgi_param REQUEST_SCHEME $scheme; uwsgi_param HTTPS $https if_not_empty; uwsgi_param REMOTE_ADDR $remote_addr; uwsgi_param REMOTE_PORT $remote_port; uwsgi_param SERVER_PORT $server_port; uwsgi_param SERVER_NAME $server_name; `` To sum it up: What's not available in the nginx params but in the allowed mailman params: HOST, HTTP_COOKIE, HTTP_FORWARDED_FOR, HTTP_HOST, HTTP_X_FORWARDED_FOR, LOGNAME, SCRIPT_NAME, USER What's not available in the allowed mailman params, but in the nginx params: CONTENT_LENGTH, DOCUMENT_ROOT, SERVER_PROTOCOL, REQUEST_SCHEME, HTTPS, REMOTE_PORT I guess one of the params from the second list is needed to keep nginx happy? Or is it the other way round and I now need to provide a param, that I haven't before? -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1744739 Title: 2.1.25 login based pages not working with uwsgi To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions From mark at msapiro.net Fri Jan 26 20:47:01 2018 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 27 Jan 2018 01:47:01 -0000 Subject: [Bug 1744739] Re: 2.1.25 login based pages not working with uwsgi References: <151663514548.4431.13685248957496009295.malonedeb@wampee.canonical.com> Message-ID: <151701762117.15797.15893350573605218329.malone@gac.canonical.com> It shouldn't be that you have to provide a "new" param because all we're doing is passing the ones in the whitelist if they are provided. If a param is not provided it can't be passed, but 2.1.24 works without it so 2.1.25 should too. As far as ones we don't pass that are provided, I'm guessing CONTENT_LENGTH might be the issue, but I'm having trouble understanding why. I'm having difficulty because I'm missing a piece here. I.e. uwsgi presumably expects to invoke a wsgi application, but the normal flow in Mailman is the web server invokes a CGI wrapper (say private) which is one of the things compiled using the code in src/common.c and which lives in Mailman at $prefix/cgi-bin/private. That wrapper is SETGID to Mailman's group. It does some checks, trims the environment and invokes $prefix/scripts/driver which understands which CGI is requested and invokes (in this example) Mailman/Cgi/private.py. None of this is a wsgi application. So what is the flow in your case? One basic question is how do you install Mailman. If you build it from source, you could just edit src/common.c to add CONTENT_LENGTH=, DOCUMENT_ROOT=, SERVER_PROTOCOL=, REQUEST_SCHEME=, HTTPS= and REMOTE_PORT= to the keepenvars list and see if that lets it work. Also, I have a somewhat uneasy feeling about this because even though I said I thought this was the likely cause, if it is I would expect it to affect all the CGIs. Does listinfo work? If so, then this trimming of the environment may not be the issue after all. If listinfo works, then you might try in your 2.1.24 installation, replacing the two occurrences of cgidata.getvalue with cgidata.getfirst in Mailman/Cgi/private.py and see if that breaks it. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1744739 Title: 2.1.25 login based pages not working with uwsgi To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions From 1744739 at bugs.launchpad.net Sat Jan 27 13:29:27 2018 From: 1744739 at bugs.launchpad.net (David Runge) Date: Sat, 27 Jan 2018 18:29:27 -0000 Subject: [Bug 1744739] Re: 2.1.25 login based pages not working with uwsgi References: <151663514548.4431.13685248957496009295.malonedeb@wampee.canonical.com> Message-ID: <151707776736.7642.5640214285160743896.malone@soybean.canonical.com> I just patched src/common.c with the mentioned parameters in the Arch package (see attachment) and now 2.1.25 works! ** Patch added: "adding nginx params to the list of allowed params in src/common.c" https://bugs.launchpad.net/mailman/+bug/1744739/+attachment/5044101/+files/02-mailman-2.1.25-nginx-headers.patch -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1744739 Title: 2.1.25 login based pages not working with uwsgi To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions From mark at msapiro.net Sat Jan 27 14:11:49 2018 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 27 Jan 2018 19:11:49 -0000 Subject: [Bug 1744739] Re: 2.1.25 login based pages not working with uwsgi References: <151663514548.4431.13685248957496009295.malonedeb@wampee.canonical.com> Message-ID: <151708030953.15766.3981663626192496200.malone@gac.canonical.com> OK, thanks. I'll add these in the next release. ** Changed in: mailman Importance: Undecided => Low ** Changed in: mailman Status: New => In Progress ** Changed in: mailman Milestone: None => 2.1.26 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1744739 Title: 2.1.25 login based pages not working with uwsgi To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions From 1744739 at bugs.launchpad.net Sat Jan 27 20:46:01 2018 From: 1744739 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Sun, 28 Jan 2018 01:46:01 -0000 Subject: [Bug 1744739] Re: 2.1.25 login based pages not working with uwsgi References: <151663514548.4431.13685248957496009295.malonedeb@wampee.canonical.com> Message-ID: <151710396451.4088.11402978286060891659.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1744739 Title: 2.1.25 login based pages not working with uwsgi To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions From mark at msapiro.net Sat Jan 27 20:46:11 2018 From: mark at msapiro.net (Mark Sapiro) Date: Sun, 28 Jan 2018 01:46:11 -0000 Subject: [Bug 1744739] Re: 2.1.25 login based pages not working with uwsgi References: <151663514548.4431.13685248957496009295.malonedeb@wampee.canonical.com> Message-ID: <151710397226.25861.5791799490610086187.launchpad@wampee.canonical.com> ** Changed in: mailman Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1744739 Title: 2.1.25 login based pages not working with uwsgi To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1744739/+subscriptions From drs at sieborger.nom.za Mon Jan 29 10:09:25 2018 From: drs at sieborger.nom.za (=?utf-8?q?David_Sieb=C3=B6rger?=) Date: Mon, 29 Jan 2018 15:09:25 -0000 Subject: [Merge] lp:~dsieborger/mailman/recaptcha into lp:mailman/2.1 Message-ID: <151723856051.29798.2371709095739885124.launchpad@ackee.canonical.com> David Sieb?rger has proposed merging lp:~dsieborger/mailman/recaptcha into lp:mailman/2.1. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~dsieborger/mailman/recaptcha/+merge/336782 This adds support for using the Google reCAPTCHA service to protect the list subscription form from spam bots. Our Mailman installation has been targeted by spam bots which are able to defeat the protection offered by SUBSCRIBE_FORM_SECRET and SUBSCRIBE_FORM_MIN_TIME, and they were sending invitations at a rate of ~10 per minute. To enable this, sign up for the service at https://www.google.com/recaptcha to create a pair of keys for your site. Once those keys are set as the configuration variables RECAPTCHA_SECRET_KEY and RECAPTCHA_SITE_KEY, Mailman/Cgi/listinfo.py will show the reCAPTCHA interface on the list subscription form, and Mailman/Cgi/subscribe.py will verify that the captcha was correctly completed via a Google API. I've avoided adding any text to the listinfo.html template as I wouldn't be able to translate it, but reCAPTCHA's UI does show the "I'm not a robot" prompt according to the browser's language preferences. This was inspired by an existing patch[1] by Andrea Veri, but uses reCAPTCHA v2 as the reCAPTCHA v1 API is about to be discontinued. [1] https://www.dragonsreach.it/2014/05/03/adding-recaptcha-support-to-mailman/ -- Your team Mailman Coders is requested to review the proposed merge of lp:~dsieborger/mailman/recaptcha into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 16412 bytes Desc: not available URL: From futatuki at poem.co.jp Tue Jan 30 00:24:21 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Tue, 30 Jan 2018 05:24:21 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 Message-ID: <151728985881.14292.2285244474172961974.launchpad@ackee.canonical.com> Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/336810 Update Japanese translation of Defaults.py.in for lp:mailman/2.1 rev 1738 change. -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 1563 bytes Desc: not available URL: From noreply at launchpad.net Tue Jan 30 00:43:22 2018 From: noreply at launchpad.net (noreply at launchpad.net) Date: Tue, 30 Jan 2018 05:43:22 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 In-Reply-To: <151728985881.14292.2285244474172961974.launchpad@ackee.canonical.com> Message-ID: <151729100122.3710.1241087791416113810.launchpad@ackee.canonical.com> The proposal to merge lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/336810 -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. From futatuki at poem.co.jp Tue Jan 30 03:14:54 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Tue, 30 Jan 2018 08:14:54 -0000 Subject: [Bug 1746189] [NEW] wrong usage of _() in Mailman/Cgi/subscribe.py Message-ID: <151730009476.15391.1007149142606868031.malonedeb@gac.canonical.com> Public bug reported: When I rebuild mailman.pot on lp:mailman/2.1 rev 1739, I found msgid added on rev 1738 are corrupted. This is caused by wrong _() usage. ** Affects: mailman Importance: Undecided Status: New ** Patch added: "subscribe.py.diff" https://bugs.launchpad.net/bugs/1746189/+attachment/5045430/+files/subscribe.py.diff -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1746189 Title: wrong usage of _() in Mailman/Cgi/subscribe.py To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1746189/+subscriptions From futatuki at poem.co.jp Tue Jan 30 03:46:14 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Tue, 30 Jan 2018 08:46:14 -0000 Subject: [Bug 1746189] Re: wrong usage of _() in Mailman/Cgi/subscribe.py References: <151730009476.15391.1007149142606868031.malonedeb@gac.canonical.com> Message-ID: <151730197518.17298.16961274136874157038.launchpad@chaenomeles.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1746189 Title: wrong usage of _() in Mailman/Cgi/subscribe.py To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1746189/+subscriptions From mark at msapiro.net Tue Jan 30 11:34:10 2018 From: mark at msapiro.net (Mark Sapiro) Date: Tue, 30 Jan 2018 16:34:10 -0000 Subject: [Bug 1746189] Re: wrong usage of _() in Mailman/Cgi/subscribe.py References: <151730009476.15391.1007149142606868031.malonedeb@gac.canonical.com> Message-ID: <151733005127.7273.14481958772809117933.malone@soybean.canonical.com> Thank you very much for finding this. I have fixed id somewhat differently, and also updated mailman.pot, but your report was very helpful. ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Status: New => Fix Committed ** Changed in: mailman Milestone: None => 2.1.26 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1746189 Title: wrong usage of _() in Mailman/Cgi/subscribe.py To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1746189/+subscriptions From futatuki at poem.co.jp Tue Jan 30 12:41:22 2018 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Tue, 30 Jan 2018 17:41:22 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 Message-ID: <151733408006.29741.851158140107459757.launchpad@ackee.canonical.com> Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/336861 Update Japanese message catalog for lp:mailman/2.1 rev 1740. -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 620 bytes Desc: not available URL: From noreply at launchpad.net Tue Jan 30 14:47:27 2018 From: noreply at launchpad.net (noreply at launchpad.net) Date: Tue, 30 Jan 2018 19:47:27 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 In-Reply-To: <151733408006.29741.851158140107459757.launchpad@ackee.canonical.com> Message-ID: <151734164582.3711.1542172181200818434.launchpad@ackee.canonical.com> The proposal to merge lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/336861 -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1.