[Merge] lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1

Yasuhito FUTATSUKI at POEM futatuki at poem.co.jp
Sun Jun 17 09:05:34 EDT 2018


Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1.

Commit message:
i18nize whence candidate message strings

Requested reviews:
  Mailman Coders (mailman-coders)

For more details, see:
https://code.launchpad.net/~futatuki/mailman/i18n-add-whence-to-adminack-templates/+merge/348127

This is a solution of problem left in mp+347992.

To mark whence messages for pygettext, I introduced dummy function i18n.D_(s) returns s it self,
and then added "-k D_" option to pygettext commandline in messages/Makefile.in.
This costs extra function call on execute, for its maintenancebility.

I've picked up whence candidate message strings except from bin/add_member, bin/delete_member, and cron/disabled, and tested with ja translation (temporary for test, not included in this proposal).

Note:
* whence messages for user conformation of subscribe and unsubscribe are inconsistent.
  For subscribe they are 'via email confirmation' and 'via web confirmation', but
  for unsubscribe they are 'email confirmation' and 'web confirmation'.
* admin approval for unsubscription dosen't report whence because 
  ListAdmin.__handleunsubscription() calls ApproveDeleteMember() without whence option.

-- 
Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/i18n-add-whence-to-adminack-templates into lp:mailman/2.1.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 7477 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/mailman-coders/attachments/20180617/38cba25f/attachment.diff>


More information about the Mailman-coders mailing list