From futatuki at poem.co.jp Tue Nov 5 17:50:34 2019 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Tue, 05 Nov 2019 22:50:34 -0000 Subject: [Bug 1851442] [NEW] MailList.AddMember crashes in a certain condition Message-ID: <157299423430.2617.9283469890592885768.malonedeb@gac.canonical.com> Public bug reported: MailList.AddMember crashes with UnicodeDecodeError if all conditions below are satisfied. * subscribe_policy of the lists is 1 or 3 (user confirmaion required) * charset of preferred_language of the list is other than us-ascii * translation for ' from %(remote)s' in the language contains other than us-ascii character the patch attached may fix it. ** Affects: mailman Importance: Undecided Status: New ** Patch added: "fix_AddMember_patch.txt" https://bugs.launchpad.net/bugs/1851442/+attachment/5303123/+files/fix_AddMember_patch.txt ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1851442 Title: MailList.AddMember crashes in a certain condition To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1851442/+subscriptions From mark at msapiro.net Fri Nov 8 14:15:52 2019 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 08 Nov 2019 19:15:52 -0000 Subject: [Bug 1845751] Re: cc modification due to nodup setting breaks DKIM & thus DMARC References: <156963231161.15808.17034191154411525924.malonedeb@gac.canonical.com> Message-ID: <157324055328.30821.4333567315359097508.malone@wampee.canonical.com> I've been trying to decide what to do about this, and I've come up with a plan. My issue with the @iank approach is it focuses solely on DMARC and I think there could be other valid reasons for not wanting to break DKIM in general regardless of DMARC. I considered a 'dont_break_dkim' switch that would trump any message modifications, possibly based on there being a DKIM sig in the message and what was signed, but even without those conditions this is too big a change this late in the MM 2.1 lifecycle. So I've decided a 'drop_cc' switch with Yes the default and meaning current behavior, but No meaning don't modify the Cc: in AvoidDuplicates.py is just what @eblake is looking for and should also satisfy @iank as far as not breaking DKIM for DMARC is concerned even though it would apply to all messages and not just those where DMARC might be an issue. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1845751 Title: cc modification due to nodup setting breaks DKIM & thus DMARC To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1845751/+subscriptions From mark at msapiro.net Fri Nov 8 16:53:38 2019 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 08 Nov 2019 21:53:38 -0000 Subject: [Bug 1851442] Re: MailList.AddMember crashes in a certain condition References: <157299423430.2617.9283469890592885768.malonedeb@gac.canonical.com> Message-ID: <157325001913.31178.14447281629599355959.malone@wampee.canonical.com> Thanks for the report and suggested fix. ** Changed in: mailman Importance: Undecided => Medium ** Changed in: mailman Status: New => Fix Committed ** Changed in: mailman Milestone: None => 2.1.30 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1851442 Title: MailList.AddMember crashes in a certain condition To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1851442/+subscriptions From 1845751 at bugs.launchpad.net Fri Nov 8 16:52:48 2019 From: 1845751 at bugs.launchpad.net (Launchpad Bug Tracker) Date: Fri, 08 Nov 2019 21:52:48 -0000 Subject: [Bug 1845751] Re: cc modification due to nodup setting breaks DKIM & thus DMARC References: <156963231161.15808.17034191154411525924.malonedeb@gac.canonical.com> Message-ID: <157324997041.9314.6244969722892443931.launchpad@ackee.canonical.com> ** Branch linked: lp:mailman/2.1 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1845751 Title: cc modification due to nodup setting breaks DKIM & thus DMARC To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1845751/+subscriptions From mark at msapiro.net Fri Nov 8 16:54:46 2019 From: mark at msapiro.net (Mark Sapiro) Date: Fri, 08 Nov 2019 21:54:46 -0000 Subject: [Bug 1845751] Re: cc modification due to nodup setting breaks DKIM & thus DMARC References: <156963231161.15808.17034191154411525924.malonedeb@gac.canonical.com> Message-ID: <157325008741.31102.1666386295905272480.launchpad@wampee.canonical.com> ** Changed in: mailman Importance: Wishlist => Low ** Changed in: mailman Status: Triaged => Fix Committed ** Changed in: mailman Milestone: None => 2.1.30 ** Changed in: mailman Assignee: (unassigned) => Mark Sapiro (msapiro) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1845751 Title: cc modification due to nodup setting breaks DKIM & thus DMARC To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1845751/+subscriptions From ian at iankelling.org Sat Nov 9 10:10:38 2019 From: ian at iankelling.org (Ian Kelling) Date: Sat, 09 Nov 2019 15:10:38 -0000 Subject: [Bug 1845751] Re: cc modification due to nodup setting breaks DKIM & thus DMARC References: <156963231161.15808.17034191154411525924.malonedeb@gac.canonical.com> Message-ID: <157331223840.6582.4494204564480702094.malone@gac.canonical.com> Awesome. Thank you Mark! This makes the behavior consistent for all users, which is probably the best thing overall. Note, this was an issue in Mailman 3 too as far as I could tell from glancing at the code. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1845751 Title: cc modification due to nodup setting breaks DKIM & thus DMARC To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1845751/+subscriptions From mark at msapiro.net Sat Nov 9 12:39:37 2019 From: mark at msapiro.net (Mark Sapiro) Date: Sat, 09 Nov 2019 17:39:37 -0000 Subject: [Bug 1845751] Re: cc modification due to nodup setting breaks DKIM & thus DMARC References: <156963231161.15808.17034191154411525924.malonedeb@gac.canonical.com> Message-ID: <157332117742.31407.8426218491705135527.malone@wampee.canonical.com> See https://gitlab.com/mailman/mailman/issues/647 ** Bug watch added: gitlab.com/mailman/mailman/issues #647 https://gitlab.com/mailman/mailman/issues/647 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1845751 Title: cc modification due to nodup setting breaks DKIM & thus DMARC To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1845751/+subscriptions From futatuki at poem.co.jp Mon Nov 11 09:43:26 2019 From: futatuki at poem.co.jp (Yasuhito FUTATSUKI at POEM) Date: Mon, 11 Nov 2019 14:43:26 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 Message-ID: <157348340265.24470.10911444976251609654.launchpad@ackee.canonical.com> Yasuhito FUTATSUKI at POEM has proposed merging lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. Commit message: update Japanese translation for lp:mailman/2.1 rev 1825-1826 Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/375388 -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1. -------------- next part -------------- A non-text attachment was scrubbed... Name: review-diff.txt Type: text/x-diff Size: 2641 bytes Desc: not available URL: From noreply at launchpad.net Tue Nov 12 14:35:50 2019 From: noreply at launchpad.net (noreply at launchpad.net) Date: Tue, 12 Nov 2019 19:35:50 -0000 Subject: [Merge] lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 In-Reply-To: <157348340265.24470.10911444976251609654.launchpad@ackee.canonical.com> Message-ID: <157358734692.8946.17839692125136188975.launchpad@ackee.canonical.com> The proposal to merge lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~futatuki/mailman/2.1-ja-translation/+merge/375388 -- Your team Mailman Coders is requested to review the proposed merge of lp:~futatuki/mailman/2.1-ja-translation into lp:mailman/2.1.