[Mailman-Developers] nasty admin Cookie bug (and fix)

Scott scott@chronis.pobox.com
Sun, 31 May 1998 15:12:04 -0400


there is a bug in the admin cgi changes that i posted.  the block of
code making general list changes fires from some brownsers when you
log on and press enter to submit the data instead of clicking the
submit button. 

the reason is that the code knows to process the login when the
button is pressed because of it's name. that data is not submitted
from some browsers when you submit the form by pressing enter instead
of clicking on the button.

since not much data is submitted, it wipes out a lot of
the list information. bad bad bad!

anyway, the fix is simple enough (against the previous patch and the
substituted isAuthenticted function).

scott


chronis 3:01pm $ cvs diff -r1.4 admin
Index: admin
===================================================================
RCS file: /usr/local/cvsroot/mailman/cgi/admin,v
retrieving revision 1.4
diff -r1.4 admin
689c690,692
<     if category != 'members' and not cgi_info.has_key("request_login"):
---
>     if category != 'members' and \
>       not cgi_info.has_key("request_login") and \
>       len(cgi_info.keys()) > 1: