[Mailman-Developers] BUGS: URL vs file pathnames

Greg Stein gstein@lyra.org
Sun, 08 Nov 1998 20:36:05 -0800


Hello...

There are a number of obsolete files in the distribution. Should be
torched.
  Mailman/Archiver.py
  Mailman/pipermail.py
  Mailman/HyperArch.py
  Mailman/HyperDatabase.py


Also, there is a general problem in the code with using os.path.join to
construct URLs. A URL is NOT a file path. You don't want to use ":" or
"\" if Mailman is run on a different platform. The os.path.join should
go away and string concat should be used with "/".

HTMLFormatter.py: lines 96 and 299
MailList.py: 442
Cgi/admin.py: 220, 401
Cgi/archives.py: 72
Cgi/edithtml.py: 95, 161
Cgi/listinfo.py: 130
Archiver/Archiver.py: 118, 122


Also, line 101 of MailList.py has a hard-coded "/" rather than using
os.path.join.

Finally: Archiver/Archiver.py:122 should have a trailing "/" on the
public archive URL. The trailing slash prevents an internal redirection
in Apache -- this screws me because it switches the hostname from a
CNAME to the "real" hostname.

-g

--
Greg Stein, http://www.lyra.org/