[Mailman-Developers] small fix for admindb
Harald Meland
Harald.Meland@usit.uio.no
14 May 1999 11:49:19 +0200
[Gergely Madarasz]
> Hello,
>
> There were already some comments about the problems with <> characters on
> the admindb pages... here is a small fix, I hope it doesnt break anything
> else :) but I don't think it could :)
>
> --- Mailman/Cgi/admindb.py~ Sat Apr 3 18:55:45 1999
> +++ Mailman/Cgi/admindb.py Wed May 5 23:04:46 1999
> @@ -247,7 +247,7 @@
> FontSize("+1", Bold('Contents:'))
> ])
> form.AddItem(t)
> - form.AddItem(Preformatted(val[2][1]))
> + form.AddItem(Preformatted(Utils.QuoteHyperChars(val[2][1])))
> form.AddItem('<p>')
Thanks for the patch -- however, I suspect this should be fixed at a
lower level. Is Mailman (or anyone) ever likely to want unquoted
special-HTML-chars in a "Preformatted" item?
If not (which is what I suspect to be the case), then overriding
htmlformat.Preformatted.Format() would be better.
Opinions, anyone?
--
Harald