[Mailman-Developers] 1.0.1 bug in newlist?

Barry A. Warsaw bwarsaw@cnri.reston.va.us (Barry A. Warsaw)
Thu, 2 Sep 1999 11:13:42 -0400 (EDT)


>>>>> "SR" == Sean Reifschneider <jafo@tummy.com> writes:

    SR> The problem is that MailList.MailList() isn't being passed any
    SR> arguments, and so the name argument is defaulting to None.
    SR> Either newlist:85 needs to pass a name, or (perhaps better
    SR> yet) MailList.MailList.InitTempVars() needs to Do The Right
    SR> Thing (tm) (like come up with some default name) when name ==
    SR> None.

You're analysis is correct.  Here's the patch I just checked in.

-Barry

-------------------- snip snip --------------------
Index: MailList.py
===================================================================
RCS file: /projects/cvsroot/mailman/Mailman/MailList.py,v
retrieving revision 1.134
retrieving revision 1.135
diff -c -r1.134 -r1.135
*** MailList.py	1999/08/23 16:15:48	1.134
--- MailList.py	1999/09/02 15:04:14	1.135
***************
*** 261,267 ****
          """Set transient variables of this and inherited classes."""
  	self.__createlock_p = lock
  	self.__lock = LockFile.LockFile(
!             os.path.join(mm_cfg.LOCK_DIR, name) + '.lock',
              # TBD: is this a good choice of lifetime?
              lifetime = 60)
  	self._internal_name = name
--- 261,267 ----
          """Set transient variables of this and inherited classes."""
  	self.__createlock_p = lock
  	self.__lock = LockFile.LockFile(
!             os.path.join(mm_cfg.LOCK_DIR, name or '<site>') + '.lock',
              # TBD: is this a good choice of lifetime?
              lifetime = 60)
  	self._internal_name = name