[Mailman-Developers] Bug#57223: mailman: gate_news problems (fwd)

[bwarsaw@cnri.reston.va.us]

>>>>> "JT" == Jim Tittsler <jwt@dskk.co.jp> writes:

    JT> I still think it better to change nntplib.

I agree.  I'd still like to get rid of your bare except though; I'm
guessing that error_perm is probably correct because of this:

>>> import nntplib
>>> x = nntplib.NNTP('ournews')
>>> x.shortcmd('mode foobar')
Traceback (innermost last):
  File "<stdin>", line 1, in ?
  File "/depot/sundry/lib/python1.5/nntplib.py", line 158, in shortcmd
    return self.getresp()
  File "/depot/sundry/lib/python1.5/nntplib.py", line 134, in getresp
    raise error_perm, resp
nntplib.error_perm: 500 Syntax error or bad command

The Right Thing To Do is to recast the nntplib errors as exception
classes and perhaps use it's base class in the except.  I'd be willing
to make this change, and merge in your patch, but you'll need to
resend your patch with the standard email disclaimer appended.  See

    http://www.python.org/patches/

for details.  Would you be willing to do that?

Thanks,
-Barry