[Mailman-Developers] using https for admin purposes

[Dan Ohnesorg]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

--546564545-459075905-960824974=:27940
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <Pine.LNX.4.21.0006121807381.27940@poli.feld.cvut.cz>

I have tried last CVS version and I have find some bug, which was also in
1.x version too. The admin.py (and other) uses for members addresses
formating function:

mlist.GetAbsoluteOptionsURL(member, obscure=1)

which will use http://, when it is set in list options. I think it will be
match better to use GetOptionsURL(...relative=1), becouse it is legal to
use http for users and https for admins.

Patch which makes this is attached. It will be possible to switch https X
https according to enviroment created by webserver, but I think, so it is
good enought.

cheers
dan


-- 
                    ________________________________________
DDDDDD             
DD   DD                Dan Ohnesorg, supervisor on POWER     
DD  OOOO               Dan@feld.cvut.cz
DD OODDOO              Dep. of Power Engineering
DDDDDD OO              CTU FEL Prague, Bohemia
   OO  OO              work: +420 2 24352785;+420 2 24972109
    OOOO               home: +420 311 679679;+420 311 679311
                    ________________________________________

Nejztracenejsi den naseho zivota
je ten, kdy jsme se nezasmali.

--546564545-459075905-960824974=:27940
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="mailman.https.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.21.0006121809260.27940@poli.feld.cvut.cz>
Content-Description: 
Content-Disposition: attachment; filename="mailman.https.patch"

ZGlmZiAtdXIgbWFpbG1hbjIub2xkL01haWxtYW4vQ2dpL2FkbWluLnB5IG1h
aWxtYW4yL01haWxtYW4vQ2dpL2FkbWluLnB5DQotLS0gbWFpbG1hbjIub2xk
L01haWxtYW4vQ2dpL2FkbWluLnB5CU1vbiBKdW4gMTIgMTY6NTg6MTIgMjAw
MA0KKysrIG1haWxtYW4yL01haWxtYW4vQ2dpL2FkbWluLnB5CU1vbiBKdW4g
MTIgMTc6NDI6MjAgMjAwMA0KQEAgLTU3MSw3ICs1NzEsNyBAQA0KICAgICAg
ICAgYnV0dG9ucyA9IFtdDQogICAgICAgICBmb3IgY2kgaW4gY2h1bmtfaW5k
aWNlczoNCiAgICAgICAgICAgICBzdGFydCwgZW5kID0gY2h1bmtzW2NpXVsw
XSwgY2h1bmtzW2NpXVstMV0NCi0JICAgIHVybCA9IG1saXN0LkdldEFic29s
dXRlU2NyaXB0VVJMKCdhZG1pbicpDQorCSAgICB1cmwgPSBtbGlzdC5HZXRT
Y3JpcHRVUkwoJ2FkbWluJywgcmVsYXRpdmU9MSkNCiAgICAgICAgICAgICBi
dXR0b25zLmFwcGVuZCgiPGEgaHJlZj0lcy9tZW1iZXJzP2NodW5rPSVkPiBm
cm9tICVzIHRvICVzIDwvYT4iDQogICAgICAgICAgICAgICAgICAgICAgICAg
ICAgJSAoIHVybCwgIGNpLCBzdGFydCwgZW5kKSkNCiAgICAgICAgIGJ1dHRv
bnMgPSBhcHBseShVbm9yZGVyZWRMaXN0LCB0dXBsZShidXR0b25zKSkNCkBA
IC01ODEsNyArNTgxLDcgQEANCiAgICAgICAgIGZvb3RlciA9ICI8cD4iDQog
ICAgIGZvciBtZW1iZXIgaW4gYWxsOg0KICAgICAgICAgbXRleHQgPSAnPGEg
aHJlZj0iJXMiPiVzPC9hPicgJSAoDQotICAgICAgICAgICAgbWxpc3QuR2V0
QWJzb2x1dGVPcHRpb25zVVJMKG1lbWJlciwgb2JzY3VyZT0xKSwNCisgICAg
ICAgICAgICBtbGlzdC5HZXRPcHRpb25zVVJMKG1lbWJlciwgb2JzY3VyZT0x
LCByZWxhdGl2ZT0xKSwNCiAgICAgICAgICAgICBtbGlzdC5HZXRVc2VyU3Vi
c2NyaWJlZEFkZHJlc3MobWVtYmVyKSkNCiAgICAgICAgIGNlbGxzID0gW210
ZXh0ICsgIjxpbnB1dCB0eXBlPWhpZGRlbiBuYW1lPXVzZXIgdmFsdWU9JXM+
IiAlIChtZW1iZXIpLA0KICAgICAgICAgICAgICAgICAgQ2VudGVyKENoZWNr
Qm94KG1lbWJlciArICJfc3Vic2NyaWJlZCIsICJvbiIsIDEpLkZvcm1hdCgp
KV0NCmRpZmYgLXVyIG1haWxtYW4yLm9sZC9NYWlsbWFuL0NnaS9oYW5kbGVf
b3B0cy5weSBtYWlsbWFuMi9NYWlsbWFuL0NnaS9oYW5kbGVfb3B0cy5weQ0K
LS0tIG1haWxtYW4yLm9sZC9NYWlsbWFuL0NnaS9oYW5kbGVfb3B0cy5weQlN
b24gSnVuIDEyIDE2OjU4OjEyIDIwMDANCisrKyBtYWlsbWFuMi9NYWlsbWFu
L0NnaS9oYW5kbGVfb3B0cy5weQlNb24gSnVuIDEyIDE3OjQ2OjA0IDIwMDAN
CkBAIC0xNjIsNyArMTYyLDcgQEANCiAgICAgICAgICAgICAgICAgICAgIGFk
ZHIgPSBVdGlscy5PYnNjdXJlRW1haWwoYWRkcnNbMF0pDQogICAgICAgICAg
ICAgICAgICAgICBpZiBtbGlzdC5vYnNjdXJlX2FkZHJlc3NlczoNCiAgICAg
ICAgICAgICAgICAgICAgICAgICBhZGRyID0gVXRpbHMuT2JzY3VyZUVtYWls
KGFkZHIpDQotICAgICAgICAgICAgICAgICAgICB1cmwgPSBtbGlzdC5HZXRB
YnNvbHV0ZU9wdGlvbnNVUkwoYWRkcikNCisgICAgICAgICAgICAgICAgICAg
IHVybCA9IG1saXN0LkdldE9wdGlvbnNVUkwoYWRkciwgcmVsYXRpdmU9MSkN
CiAgICAgICAgICAgICAgICAgICAgIGxpbmsgPSBMaW5rKHVybCwgbWxpc3Qu
cmVhbF9uYW1lKQ0KICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIG1saXN0
LmludGVybmFsX25hbWUoKSwgbGluaw0KIA0KZGlmZiAtdXIgbWFpbG1hbjIu
b2xkL01haWxtYW4vSFRNTEZvcm1hdHRlci5weSBtYWlsbWFuMi9NYWlsbWFu
L0hUTUxGb3JtYXR0ZXIucHkNCi0tLSBtYWlsbWFuMi5vbGQvTWFpbG1hbi9I
VE1MRm9ybWF0dGVyLnB5CU1vbiBKdW4gMTIgMTY6NTg6MTIgMjAwMA0KKysr
IG1haWxtYW4yL01haWxtYW4vSFRNTEZvcm1hdHRlci5weQlNb24gSnVuIDEy
IDE4OjA0OjAxIDIwMDANCkBAIC0yOTksNyArMjk5LDcgQEANCiAgICAgICAg
IHJldHVybiBjb250YWluZXINCiANCiAgICAgZGVmIEZvcm1hdEZvcm1TdGFy
dChzZWxmLCBuYW1lLCBleHRyYT0nJyk6DQotCWJhc2VfdXJsID0gc2VsZi5H
ZXRBYnNvbHV0ZVNjcmlwdFVSTChuYW1lKQ0KKwliYXNlX3VybCA9IHNlbGYu
R2V0U2NyaXB0VVJMKG5hbWUsIHJlbGF0aXZlPTEpDQogICAgICAgICBpZiBl
eHRyYToNCiAgICAgICAgICAgICBmdWxsX3VybCA9ICIlcy8lcyIgJSAoYmFz
ZV91cmwsIGV4dHJhKQ0KICAgICAgICAgZWxzZToNCg==
--546564545-459075905-960824974=:27940--