[Mailman-Developers] Bug in CookHeaders.py

[Jerzy Hodor]

   Hello,

I have just discovered a bug in Mailman 2.0beta6. When you set up a list to
post replies to list, and user receives confirmation note about subsciption,
the CookHandlers module trashes content of  'Reply-To' field. Accordingly to
comments in this code there is wrong written condition in it.You should
change it from:
    if not fasttrack or msg.get('reply-to'):
to:
    if not fasttrack or not msg.get('reply-to'):
or even to cleaner form:
    if not (fasttrack and msg.get('reply-to')):

Here is diff -uNr of CookHeaders.py.orig CookHeaders.py

<---------cut here
--- CookHeaders.py.orig Sun Oct  8 12:53:40 2000
+++ CookHeaders.py      Sun Oct  8 12:54:30 2000
@@ -79,7 +79,7 @@
     # or if there is already a reply-to set.  If the user has set
     # one we assume they have a good reason for it, and we don't
     # second guess them.
-    if not fasttrack or msg.get('reply-to'):
+    if not fasttrack or not msg.get('reply-to'):
         # Set Reply-To: header to point back to this list
         if mlist.reply_goes_to_list == 1:
             msg['Reply-To'] = mlist.GetListEmail()
<---------cut here

Hope this helps developing your great program!
Sincerely yours,

--
Jerzy Hodor

PS. Yes, I have posted this bug and patch on sourceforge :-)