[Mailman-Developers] [PATCH] A small bug fixed in --with-python patch

[Ben Gertzfield]

>>>>> "BAW" == Barry A Warsaw <barry@zope.com> writes:

    BAW> A couple of nits...

    BAW> First, since your patch changes things so that the scripts no
    BAW> longer search for `python' on your $PATH, we don't need the
    BAW> /usr/bin/env trick anymore.  So I think those lines can
    BAW> safely be changed to

    BAW>     #! @PYTHON@

    BAW> No need to generate another patch Ben, I've made this change
    BAW> myself.

Great!  That makes a lot of sense, I should have realized that. :)

    BAW> Second, we can forget about the filter directory; it's old,
    BAW> obsolete, and soon to be removed <wink>.  Third, we don't
    BAW> need #! lines in the scripts/* files, since these will always
    BAW> be executed by the wrappers, which already have @PYTHON@
    BAW> hard-coded into them.  I've changed these lines to

Ah, okay.  It's sometimes a little hard to be aware of the big picture,
but that'll work great.

    BAW>     #! -*- python -*-

    BAW> to keep the Emacs major mode dance working.

For future reference, you could also set it at the end of the file:

# Local-variables:
# major-mode:python
# End:

or something like that. :)

    BAW> Other than that, I think your patch looks fine.  It certainly
    BAW> meets my requirements, seems to work, and solves your
    BAW> problem.

    BAW> Unless I hear any objections, I'll go ahead and accept these
    BAW> changes.

Excellent!  I'm really enjoying working with Mailman.  Python is just
so clean and easy to follow, it makes my life easy. :)

Thanks for helping solve the (future) Debian users' problems.

Ben

-- 
Brought to you by the letters A and B and the number 11.
"Ohhhh, Mentos Boy!"
Debian GNU/Linux maintainer of Gimp and GTK+ -- http://www.debian.org/